fix: reject unknown indexes in HTTP queries - #173
Open
immanuwell wants to merge 1 commit into
Open
Conversation
immanuwell
force-pushed
the
fix/http-query-unknown-index
branch
from
July 15, 2026 07:06
3af7e61 to
97e4da6
Compare
Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix/http-query-unknown-index
branch
from
July 17, 2026 09:08
97e4da6 to
34ed7aa
Compare
Contributor
Author
|
@derailed addressed your suggestions, PTAL |
derailed
approved these changes
Jul 17, 2026
derailed
left a comment
derailed
left a comment
There was a problem hiding this comment.
@immanuwell Thank you for the updates. LGTM. Added Jussi/Tobias for their review.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unknown index names make
/querypanic and close the connection. Kinda rough.Return
400 Bad Requestwith a JSON error instead. Primary andByRevisionqueries still work.Repro: send
GET /querywith{"key":"","table":"test","index":"unknown"}. Before, it panics and the client gets EOF. Now it returns400.