Skip to content

ksmbd-tools: fix race conditions and thread safety in user management #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yskzalloc wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ksmbd-tools: fix race conditions and thread safety in user management #337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30cc41c
ksmbd-tools: Fix potential data race in usm_handle_logout_request()
yskzalloc May 2, 2026
1c416f0
ksmbd-tools: Fix potential data race in usm_add_guest_account()
yskzalloc May 2, 2026
02b7865
ksmbd-tools: Fix potential data race in __handle_login_request()
yskzalloc May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tools/management/user.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,9 @@ int usm_add_guest_account(char *name)
if (!user) {
ret = -EINVAL;
} else {
g_rw_lock_writer_lock(&user->update_lock);
set_user_flag(user, KSMBD_USER_FLAG_GUEST_ACCOUNT);
g_rw_lock_writer_unlock(&user->update_lock);
put_ksmbd_user(user);
}
return ret;
Expand Down Expand Up @@ -371,13 +373,13 @@ static void __handle_login_request(struct ksmbd_login_response *resp,
{
int hash_sz;

g_rw_lock_reader_lock(&user->update_lock);
resp->gid = user->gid;
resp->uid = user->uid;
resp->status = user->flags;
resp->status |= KSMBD_USER_FLAG_OK;

resp->status = user->flags | KSMBD_USER_FLAG_OK;
if (user->ngroups)
resp->status |= KSMBD_USER_FLAG_EXTENSION;
g_rw_lock_reader_unlock(&user->update_lock);

hash_sz = usm_copy_user_passhash(user,
resp->hash,
Expand Down Expand Up @@ -456,6 +458,7 @@ int usm_handle_logout_request(struct ksmbd_logout_request *req)
if (!user)
return -ENOENT;

g_rw_lock_writer_lock(&user->update_lock);
if (req->account_flags & KSMBD_USER_FLAG_BAD_PASSWORD) {
if (user->failed_login_count < 10)
user->failed_login_count++;
Expand All @@ -465,6 +468,7 @@ int usm_handle_logout_request(struct ksmbd_logout_request *req)
user->failed_login_count = 0;
user->flags &= ~KSMBD_USER_FLAG_DELAY_SESSION;
}
g_rw_lock_writer_unlock(&user->update_lock);

put_ksmbd_user(user);
return 0;
Expand Down
Loading