fix(one): 入库目录包名对齐 dsh-harness-one(修市场 npm 字段关联) - #96
Merged
Merged
Conversation
awesome 清单的 probe-npm 从条目子目录 package.json 抓 name 作为市场 npm 字段,并要求 npm 包的 repository 与仓库 url 双向关联。入库目录 dsh-ccpg-one 的 name 仍是停更老包 dsh-ccpg-one(npm 停在 0.4.1, repository 还是改名前的 harness-one),抓取会得到错误关联: - 装的将是停更老包而非 dsh-harness-one - repository 匹配失败时 npm 字段直接判 null(GitHub-only 条目) 改入库目录 package.json name/bin 为 dsh-harness-one(脚本全部按路径 引用该文件读 version/依赖,无按 name 解析的运行时依赖;装配产物 name 本就独立硬编码 dsh-harness-one,不受影响)。install.js 的 PKG 常量与提示文案、install.test.mjs 断言同步。
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
awesome 清单 CI(probe-npm)从投稿条目子目录的
package.json抓name作为市场npm字段,并校验该 npm 包的repository与条目 url 关联。入库目录
dsh-plugins/dsh-ccpg-one/package.json的name仍是停更老包dsh-ccpg-one(npm 停在 0.4.1,repository 还是改名前的harness-one)。保持现状的后果:npm字段被判null,条目降级为 GitHub-only改动
dsh-plugins/dsh-ccpg-one/package.json:name/bin改为dsh-harness-onebin/install.js:PKG常量与提示文案同步test/install.test.mjs:断言同步目录名不动(git 路径与 awesome 条目 url 已对齐维护者要求);脚本全部按路径读该 package.json(version/sidebar 依赖),无按 name 的模块解析;
assemble-one.sh产物的 name 本就独立硬编码dsh-harness-one。验证
npm test全量 48 套通过(含改后的 install 3 组)sh dsh-plugins/build-web.sh双构建通过sh dsh-plugins/assemble-one.sh --check装配校验通过