[cuda_xpu_alignment] [Inductor] pick_deterministic_choice checks ExternKernelChoice instead of ExternKernelCaller; deterministic extern-kernel preference is silently bypassed#34
Draft
Stonepia wants to merge 1 commit into
Conversation
[cuda_xpu_alignment] [Inductor] pick_deterministic_choice checks ExternKernelChoice instead of ExternKernelCaller; deterministic extern-kernel preference is silently bypassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[cuda_xpu_alignment] [Inductor] pick_deterministic_choice checks ExternKernelChoice instead of ExternKernelCaller; deterministic extern-kernel preference is silently bypassed
Fixes https://github.com/intel-sandbox/agentic_xpu/issues/11
Root Cause: pick_deterministic_choice() incorrectly uses isinstance(choice, ExternKernelChoice) when choices contains ExternKernelCaller instances. ExternKernelChoice is a factory class; its bind() method returns ExternKernelCaller objects. The isinstance check never matches, causing deterministic mode to bypass extern-kernel preference.
Diff stat: