[cuda_xpu_alignment] F.gumbel_softmax(tau=0.0) silently produces all-NaN output instead of raising ValueError#33
Closed
Stonepia wants to merge 1 commit into
Closed
[cuda_xpu_alignment] F.gumbel_softmax(tau=0.0) silently produces all-NaN output instead of raising ValueError#33Stonepia wants to merge 1 commit into
Stonepia wants to merge 1 commit into
Conversation
[cuda_xpu_alignment] F.gumbel_softmax(tau=0.0) silently produces all-NaN output instead of raising ValueError
Collaborator
Author
|
Closing: issue #15 (gumbel_softmax tau=0 NaN) is device-agnostic. Upstream pytorch#184582 addresses this directly with a ValueError guard. No XPU-specific fix needed — this issue should be WAITING_UPSTREAM for pytorch#184582 to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[cuda_xpu_alignment] F.gumbel_softmax(tau=0.0) silently produces all-NaN output instead of raising ValueError
Fixes https://github.com/intel-sandbox/agentic_xpu/issues/15
Root Cause: torch.nn.functional.gumbel_softmax at torch/nn/functional.py:2229 computes
(logits + gumbels) / tauwithout validating tau. When tau=0.0, division by zero produces inf/nan that propagates through softmax, yielding all-NaN output silently. Negative tau values are similarly unguarded despite the docstring implying tau should be positive.Diff stat: