[cuda_xpu_alignment] Fix Triton HOP clone for strided mutated views (#184050)#31
Draft
Stonepia wants to merge 1 commit into
Draft
[cuda_xpu_alignment] Fix Triton HOP clone for strided mutated views (#184050)#31Stonepia wants to merge 1 commit into
Stonepia wants to merge 1 commit into
Conversation
[cuda_xpu_alignment] Fix Triton HOP clone for strided mutated views (pytorch#184050)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[cuda_xpu_alignment] Fix Triton HOP clone for strided mutated views (pytorch#184050)
Fixes https://github.com/intel-sandbox/agentic_xpu/issues/5
Root Cause: In
torch/_higher_order_ops/triton_kernel_wrap.py, thetriton_kernel_wrapper_functional_denseandtriton_kernel_wrapper_functional_fake_tensor_modefunctions useclone_preserve_stridesto clone mutated Triton kernel arguments. For strided views (e.g.,x[::2]),clone_preserve_stridescopies the full storage span, which can read past the bounds of compact Inductor temporaries, producing incorrect values. The upstream fix (commit 9a8a62c) replaces this with a newclone_preserve_strides_for_triton_kernel_wrapperthat allocates stride-compatible storage and copies only logical elements viaout.copy_(x).Diff stat: