[upstream #3549] [XPU] Enable functionalize_rng_ops on XPU (philox_rand prim + RNG decompositions)#21
Draft
Stonepia wants to merge 1 commit into
Draft
[upstream #3549] [XPU] Enable functionalize_rng_ops on XPU (philox_rand prim + RNG decompositions)#21Stonepia wants to merge 1 commit into
Stonepia wants to merge 1 commit into
Conversation
[upstream pytorch#3549] [XPU] Enable functionalize_rng_ops on XPU (philox_rand prim + RNG decompositions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[upstream pytorch#3549] [XPU] Enable functionalize_rng_ops on XPU (philox_rand prim + RNG decompositions)
Fixes https://github.com/intel-sandbox/torch-xpu-ops-exp/issues/384
Root Cause: The functionalize_rng_ops path hardcodes CUDA-only device checks via
throw_on_non_cudain three locations (decompositions_for_rng.py lines 34, 55; rng_prims.py line 118). XPU supports Philox RNG but is rejected by these gates. Additionally,philox_rand_offsetlikely queries CUDA-specific device properties.Diff stat: