[upstream #3489] [release/2.12] PT2E INT8 accuracy regression on shufflenet_v2_x1_0 (XPU): Acc@1 66.5 → 0.09 between release/2.11 and 2.12.0+xpu#19
Draft
Stonepia wants to merge 1 commit into
Conversation
[upstream pytorch#3489] [release/2.12] PT2E INT8 accuracy regression on shufflenet_v2_x1_0 (XPU): Acc@1 66.5 → 0.09 between release/2.11 and 2.12.0+xpu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[upstream pytorch#3489] [release/2.12] PT2E INT8 accuracy regression on shufflenet_v2_x1_0 (XPU): Acc@1 66.5 → 0.09 between release/2.11 and 2.12.0+xpu
Fixes https://github.com/intel-sandbox/torch-xpu-ops-exp/issues/364
Root Cause: The regression is caused by commit b3bc797 which added qconv_pointwise.tensor variant support. When PT2E quantization produces tensor-typed x_scale/x_zp (x_scale_zp_are_tensors=True path), the new lowering handles them but does not ensure w_zp is properly converted to int32 for the qconv path on XPU (unlike the qlinear path which has explicit dtype conversion at L798-806). Additionally, the TensorMeta construction failure in select_algorithm.py for XPU extern kernels means benchmarking requests get empty metas, potentially causing incorrect algorithm/kernel selection for grouped/depthwise convolutions like those in shufflenet.
Diff stat: