Skip to content

Pull Request - To do list interactive branch#3

Open
chuaindia wants to merge 30 commits into
mainfrom
Todolist-interactive-branch
Open

Pull Request - To do list interactive branch#3
chuaindia wants to merge 30 commits into
mainfrom
Todolist-interactive-branch

Conversation

@chuaindia

Copy link
Copy Markdown
Owner

In this branch following features are incorporated :

  • A new JavaScript file is added and imported as a module.
  • It contains methods related to the status updates (completed: true / false).
  • Event listener is added to the checkbox (change).
  • Items object's value are updated for completed key upon user actions.
  • A function for the "Clear all completed" button is implemented (use filter() method).
  • The updated array of items in local storage, so the user gets the correct list values after the page reloads.

@sumairq sumairq left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chuaindia ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✔️ Good commit history
✔️Linters are passing
✔️Very professional README
✔️Correct Github flow
✔️Descriptive PR

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants