To do list branch#1
Conversation
ShahierNashaat
left a comment
ShahierNashaat
left a comment
There was a problem hiding this comment.
Hi @chuaindia,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight 💯
- Correct use of GitFlow ✔️
- Descriptive commit messages ✔️
- Professional looking pull request ✔️
- Your readme looks professional ✔️
- Your code is clean and well documented ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| "homepage": "https://github.com/chuaindia/To-Do-List#readme" | ||
| } |
There was a problem hiding this comment.
- Kindly notice that the Webpack dev server is set up and running with no errors.
"devDependencies": {
"webpack": "^5.60.0",
"webpack-cli": "^4.9.1",
"webpack-dev-server": "^4.3.1"
},There was a problem hiding this comment.
This is also included in the package.json file
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, |
There was a problem hiding this comment.
- Also here you should select the webpack serv when running
npm start.
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"watch": "webpack --watch",
"start": "webpack serve --open",
"build": "webpack"
},There was a problem hiding this comment.
This is done accordingly.
| import * as stat from './status.js'; | ||
| import './style.css'; | ||
|
|
||
| let list = []; |
There was a problem hiding this comment.
- Kindly notice that the array should have some simple to do tasks.
const list = [
{
description: 'An example description in string',
completed: false,
index: 10,
},
];There was a problem hiding this comment.
List elements with proper 'description', 'completed' and 'index' is included in src/index.js.
ichala
left a comment
ichala
left a comment
There was a problem hiding this comment.
Hi @chuaindia ,
Good job so far! 👏👏👏
There are some issues that you still need to work on to go to the next project but you're almost there!
To Highlight 🎉
- Changes Implemented
Required Changes ♻️
🛑🛑 Your list is not being rendered in the UI, kindly try to fix the issues in your index.js file
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
The error is resolved. The To-Do List is available in the console. The screenshot is attached herewith. |
levy002
left a comment
levy002
left a comment
There was a problem hiding this comment.
Hello @chuaindia
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Status: APPROVED 🔥 🔥
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Thank you very much for the review. |
5 participants
The following features are incorporated :