fix(AutoMiningPlugin): progressive mode banks and mines at the chosen mine, blank keep list no longer stalls drop mode (1.0.15)

src/main/java/net/runelite/client/plugins/microbot/mining/AutoMiningPlugin.java

@@ -24,7 +24,7 @@
 )
 @Slf4j
 public class AutoMiningPlugin extends Plugin {
-    public static final String version = "1.0.14";
+    public static final String version = "1.0.15";
     @Inject
     private AutoMiningConfig config;
     @Provides

src/main/java/net/runelite/client/plugins/microbot/mining/AutoMiningScript.java

@@ -79,7 +79,7 @@ public boolean run(AutoMiningConfig config) {
 
                 updateActiveRock(config);
 
-                if (config.progressiveMode() && ensureProgressiveLocation(config)) {
+                if (config.progressiveMode() && state == State.MINING && ensureProgressiveLocation(config)) {
                     return;
                 }
 
@@ -214,7 +214,7 @@ else if (activeRock == Rocks.GEM && Rs2Player.getWorldLocation().getRegionID() =
                             }
 
                         } else {
-                            Rs2Inventory.dropAllExcept(false, config.interactOrder(), Arrays.stream(config.itemsToKeep().split(",")).map(String::trim).toArray(String[]::new));
+                            Rs2Inventory.dropAllExcept(false, config.interactOrder(), MiningBankRule.parseItemsToKeep(config.itemsToKeep()).toArray(new String[0]));
                         }
 
                         state = State.MINING;
@@ -313,9 +313,7 @@ private boolean ensureProgressiveLocation(AutoMiningConfig config) {
 
         WorldPoint targetPoint = activeLocation.getWorldPoint();
 
-        // Only update initialPlayerLocation if it's null
-        // Don't update just because player is far away (e.g., at bank) - that breaks return-to-location
-        if (initialPlayerLocation == null) {
+        if (!targetPoint.equals(initialPlayerLocation)) {
             initialPlayerLocation = targetPoint;
         }
 

src/main/java/net/runelite/client/plugins/microbot/mining/MiningBankRule.java

@@ -4,12 +4,14 @@
 
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
 import java.util.stream.Collectors;
 
 final class MiningBankRule {
     private static final String UNCUT_GEM_PREFIX = "uncut ";
+    private static final String DEFAULT_ITEM_TO_KEEP = "pickaxe";
 
     private MiningBankRule() {
     }
@@ -22,6 +24,11 @@ static List<String> parseItemNames(String itemsToBank) {
                 .collect(Collectors.toList());
     }
 
+    static List<String> parseItemsToKeep(String itemsToKeep) {
+        List<String> keep = parseItemNames(itemsToKeep);
+        return keep.isEmpty() ? Collections.singletonList(DEFAULT_ITEM_TO_KEEP) : keep;
+    }
+
     static boolean shouldBank(String itemName, Collection<Rocks> rocks, List<String> itemNames) {
         if (itemName == null) {
             return false;

src/test/java/net/runelite/client/plugins/microbot/mining/MiningBankRuleTest.java

@@ -20,6 +20,14 @@ void parsesCommaSeparatedNames() {
         assertTrue(MiningBankRule.parseItemNames(" , ").isEmpty());
     }
 
+    @Test
+    void blankKeepListFallsBackToPickaxe() {
+        assertEquals(Collections.singletonList("pickaxe"), MiningBankRule.parseItemsToKeep(""));
+        assertEquals(Collections.singletonList("pickaxe"), MiningBankRule.parseItemsToKeep(" , "));
+        assertEquals(Collections.singletonList("pickaxe"), MiningBankRule.parseItemsToKeep(","));
+        assertEquals(Collections.singletonList("pickaxe"), MiningBankRule.parseItemsToKeep(", "));
+    }
+
     @Test
     void defaultListStillBanksOres() {
         assertTrue(MiningBankRule.shouldBank("Tin ore", only(Rocks.TIN), DEFAULT_ITEMS));