[chsami]

Problem

Client error telemetry group 2525 (1 occurrence, 1 report, Microbot 2.6.33, FarmTreeRunPlugin 1.2.2, thread FarmTreeRunScript-3):

java.lang.NullPointerException: Cannot invoke "net.runelite.api.ObjectComposition.getName()" because the return value of ... is null
  at FarmTreeRunScript.isPatchEmpty:1207
  at FarmTreeRunScript.handlePlantingTree:1025
  at FarmTreeRunScript.handlePatch:907
  at FarmTreeRunScript.lambda$run$2:326

The NPE kills the loop iteration right after a sapling is planted.

Root cause

Rs2GameObject.getObjectComposition(int) in the client is @Nullable. It returns null when the client-thread read fails or times out, or when the impostor resolves to null while the patch changes after planting. isPatchEmpty dereferenced the result without a check. handlePatch had the same unguarded pattern on findObjectComposition(treePatch.getId()).getActions().

Change

• isPatchEmpty: a null composition (or null name) is treated as an empty patch, not an NPE. Every caller goes through this helper.
• handlePatch: if the tree patch composition or its actions are null, the method returns false and the loop retries on the next tick.
• handlePayment: the three "protection disabled" early returns no longer call isPatchEmpty. With protection off and PROTECT, the method returns without reading the composition or looking up the gardener. The only PROTECT caller runs only after treePlanted, so caller behaviour is unchanged.
• Plugin version 1.2.3 -> 1.2.5.

Validation

• New FarmTreeRunPatchEmptyTest (4 cases) and FarmTreeRunHandlePatchTest (3 cases). The handlePatch/handlePayment cases fail with an NPE against the previous script and pass with this change.
• ./gradlew test --tests 'net.runelite.client.plugins.microbot.farmtreerun.*' -PpluginList=FarmTreeRunPlugin: all farmtreerun tests pass.
• ./gradlew build -PpluginList=FarmTreeRunPlugin: BUILD SUCCESSFUL. Full test suite: 148 suites, 918 tests, 0 failures.

Known gaps

• Not live-tested in game. The null composition is a timing condition that is hard to reproduce on demand.
• If the composition is briefly null on a patch that is already planted, one compost/sapling use-on-object attempt can go through. The game rejects it harmlessly, and the patch is retried on the next tick.
• The version goes from 1.2.3 to 1.2.5 within this branch, so 1.2.4 is never published.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV