Repository navigation
fix(gotr): guard altar renderable cast to DynamicObject (1.5.10) - #636
Merged
chsami merged 1 commit intoOct 15, 2026
Merged
Conversation
getAvailableAltars cast every altar renderable to DynamicObject, throwing ClassCastException when the renderable is a plain Model. Check the type first and read the animation once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Client error telemetry group 1280 (GotrPlugin 1.5.9, Microbot 2.6.30): 2 occurrences across 1 report, first seen 2026-10-12, last seen 2026-10-12.
Root cause
GotrScript.getAvailableAltarsfilters guardian altars by castingx.getRenderable()toDynamicObject(twice) with no type check. When an altar's renderable is a plainModel(an idle altar with no animation), the cast throws and breaks altar selection insideenterAltar'ssleepUntilloop.Change
GotrScript.isActiveAltarRenderable(Renderable): returns false unless the renderable is aDynamicObject, readsgetAnimation()once, and returnsanimation != null && animation.getId() == 9363.DynamicObjectrenderable is treated as inactive, which matches the existing null-animation branch.GotrPluginversion 1.5.9 -> 1.5.10.Validation
GotrAltarRenderableTest(5 cases): plain Model, null, DynamicObject with no animation, different animation id, active id 9363../gradlew test -PpluginList=GotrPlugin --tests 'net.runelite.client.plugins.microbot.gotr.*' --tests 'PluginManifestVersionTest': BUILD SUCCESSFUL (GotrAltarRenderableTest 5/5, GotrPluginRoundEventTest 3/3, GotrPortalClockTest 7/7, PluginManifestVersionTest 1/1)../gradlew build -x test -PpluginList=GotrPlugin: BUILD SUCCESSFUL.Known gaps
MixologyScript.java:398and:464checkinstanceof DynamicObjectbut callgetAnimation().getId()without a null check (possible NPE). Separate defect.🤖 Generated with Claude Code
https://claude.ai/code/session_01LjtEMzQHGuq4M1Mpqk9pPV