Fix Alembic role migration truncation when renaming to worker_owner#33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DataError: value too long for type character varying(8)when the migration updatesusers.roletoworker_ownerbecause the pre-migration enum/check constrained stored values to shorter length.rolecolumn temporarily so data updates do not get truncated.Description
pool-coordinator/alembic/versions/0003_update_user_role_enum_for_new_auth_flow.pyto removeclientandworker_ownerfromold_role_enumso it reflects the actual pre-migration enum (admin,operator,user).op.batch_alter_tableinupgrade()that altersroletosa.String(length=32)before performing theUPDATEstatements.client,worker_owner) intact so the column becomes the intended enum after data migration.Testing
cd pool-coordinator && python -m pytest -q, which completed successfully with39 passed, 3 skipped.cd pool-coordinator && python -m pytest tests/integration/test_migrations_apply.py -q, which ran in this environment and reported1 skipped.Codex Task