Describe the parallel downloading, and declare the R version - #13
Merged
Conversation
R CMD build inferred a dependency on R >= 4.1.0 on every build and warned about it, because the package uses the |> pipe introduced there (R/accessEnvDat.R and R/matchData.R) without saying so in DESCRIPTION. 4.1.0 is the floor the syntax actually implies: the pipe and the \(x) function shorthand both arrive in that release, and the package uses the former in two files and the latter nowhere. %||% is defined in R/variables.R rather than taken from base, which is what keeps the floor below the 4.4.0 that base's version would require. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The section existed but did not answer the question a reader arrives with, which is whether there is an option and what it is called. Three things were in the way. Neither this section nor the daily one was in the table of contents, so a reader scanning the contents for it concluded there was nothing to find. The section described the behaviour - downloads "go out four at a time" - without naming n_workers or saying it defaults to 4. Someone looking for the argument had to read the whole paragraph to learn it exists. Both examples passed frequency = "daily", which reads as parallelism being a daily-only feature. It is not: any fetch spanning more than one time step is more than one download, and a fifteen-year monthly record is 180 of them. The examples are monthly now, and say so. Adds what it deliberately does not do, since both are easy to assume the other way: cached files are read from disk rather than re-fetched, and each accessEnvDat() call is one dataset, so SST and CHL remain two calls run one after the other. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated tidy-ups after #12, kept as separate commits.
Declare the R version
R CMD buildinferred a dependency on R >= 4.1.0 on every build and warned about it, because the package uses the|>pipe introduced there without saying so inDESCRIPTION.4.1.0 is the floor the syntax actually implies: the pipe and the
\(x)function shorthand both arrive in that release, and the package uses the former in two files (R/accessEnvDat.R,R/matchData.R) and the latter nowhere.%||%is defined inR/variables.Rrather than taken from base, which is what keeps the floor below the 4.4.0 that base's version would require.Verified: the build warning is gone, and
packageDescription("datamatch")$DependsreportsR (>= 4.1.0).Make the parallel downloading findable
The section existed but did not answer the question a reader arrives with — whether there is an option, and what it is called. Three things were in the way:
n_workersor its default of 4. It described the behaviour ("downloads go out four at a time") without saying which argument controls it or that it is on without being asked for.frequency = "daily", which reads as parallelism being a daily-only feature. It is not: any fetch spanning more than one time step is more than one download, and a fifteen-year monthly record is 180 of them. The examples are monthly now, and say so.Also adds what it deliberately does not do, since both are easy to assume the other way: cached files are read from disk rather than re-fetched, and each
accessEnvDat()call is one dataset, so SST and CHL remain two calls run one after the other.No runtime behaviour changes —
DESCRIPTIONmetadata and README prose only. All 25 table-of-contents anchors were checked against the rendered headings and resolve.🤖 Generated with Claude Code