Skip to content

[BUG](worker): Detach fn-consumer batches - #7521

Merged
tanujnay112 merged 1 commit into
mainfrom
codex/detach-fn-consumer-trace
Jul 29, 2026
Merged

[BUG](worker): Detach fn-consumer batches#7521
tanujnay112 merged 1 commit into
mainfrom
codex/detach-fn-consumer-trace

Conversation

@tanujnay112

@tanujnay112 tanujnay112 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Detach each FnConsumerManager::dispatch_batch span from the scheduled poll trace.

Why

A scheduled poll can run multiple batches concurrently via join_all, so keeping those spans under the poll conflates independent attached-function executions in one trace. Each batch is now its own trace root, while the scheduled-poll trace retains polling and GetWork visibility.

Impact

Function-batch traces can be inspected independently in Honeycomb. This changes trace topology only; it does not change function execution behavior or span volume.

Validation

  • git diff --check
  • cargo fmt --check
  • cargo test -p worker fn_consumer --lib

@github-actions

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tanujnay112
tanujnay112 marked this pull request as ready for review July 29, 2026 00:07

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@tanujnay112
tanujnay112 enabled auto-merge (squash) July 29, 2026 00:07
@tanujnay112
tanujnay112 merged commit 8e0eb87 into main Jul 29, 2026
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants