[BUG](worker): Detach fn-consumer batches - #7521
Merged
Merged
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
tanujnay112
marked this pull request as ready for review
July 29, 2026 00:07
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
tanujnay112
enabled auto-merge (squash)
July 29, 2026 00:07
HammadB
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detach each
FnConsumerManager::dispatch_batchspan from the scheduled poll trace.Why
A scheduled poll can run multiple batches concurrently via
join_all, so keeping those spans under the poll conflates independent attached-function executions in one trace. Each batch is now its own trace root, while the scheduled-poll trace retains polling andGetWorkvisibility.Impact
Function-batch traces can be inspected independently in Honeycomb. This changes trace topology only; it does not change function execution behavior or span volume.
Validation
git diff --checkcargo fmt --checkcargo test -p worker fn_consumer --lib