Skip to content

[CHORE] Split Python tests that run on main so half run on mcmr. - #6255

Closed
rescrv wants to merge 2 commits into
mainfrom
rescrv/split-ci-for-mcmr
Closed

[CHORE] Split Python tests that run on main so half run on mcmr.#6255
rescrv wants to merge 2 commits into
mainfrom
rescrv/split-ci-for-mcmr

Conversation

@rescrv

@rescrv rescrv commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Description of changes

We want to test multi-cloud, multi-region without doubling CI wait times
or the overall sum of CPU consumed. The fix is simple: We already run
multiple Python versions, so run half of them on mcmr and half on the
classic tilt file.

Test plan

CI will be the test.

Migration plan

N/A

Observability plan

Watch CI on landing.

Documentation Changes

N/A

@github-actions

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot

propel-code-bot Bot commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

The release workflow now divides the Linux Python matrix into two complementary jobs, keeping 3.9/3.11 on the classic runners while routing 3.10/3.12 through the multi-cloud multi-region path, and the shared _python-tests.yml workflow surfaces an always_multi_region input so the cluster frontend can set MULTI_REGION when either the caller or the matrix requests it.

Affected Areas

• .github/workflows/release-chromadb.yml
• .github/workflows/_python-tests.yml

This summary was automatically generated by @propel-code-bot

@rescrv
rescrv requested a review from sanketkedia January 29, 2026 17:48
Comment on lines 17 to +20
required: false
default: 'blacksmith-8vcpu-ubuntu-2404'
type: string
always_multi_region: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical

[Logic] workflow_call inputs must be declared as mapping objects; assigning always_multi_region: false leaves the input undefined and causes fromJson(inputs.always_multi_region) to fail. Define this input like the others (description, type, default) and keep the value as a JSON array string so callers can pass '[false]' or '[true]' as needed.

Context for Agents
`workflow_call` inputs must be declared as mapping objects; assigning `always_multi_region: false` leaves the input undefined and causes `fromJson(inputs.always_multi_region)` to fail. Define this input like the others (description, type, default) and keep the value as a JSON array string so callers can pass `'[false]'` or `'[true]'` as needed.

File: .github/workflows/_python-tests.yml
Line: 20

@rescrv
rescrv force-pushed the rescrv/split-ci-for-mcmr branch from 30220ae to 091f453 Compare January 29, 2026 19:30
Comment thread .github/workflows/_python-tests.yml Outdated
Comment thread .github/workflows/release-chromadb.yml
@rescrv
rescrv force-pushed the rescrv/test-add-mcmr branch from 5d56759 to 86bd3b7 Compare February 2, 2026 21:53
@rescrv
rescrv force-pushed the rescrv/split-ci-for-mcmr branch from 091f453 to 2ca8ed7 Compare February 2, 2026 21:53
@rescrv
rescrv force-pushed the rescrv/test-add-mcmr branch from 76316b8 to 4c4e146 Compare February 3, 2026 18:06
@rescrv
rescrv force-pushed the rescrv/split-ci-for-mcmr branch from 2ca8ed7 to 49c3789 Compare February 3, 2026 18:40
Comment thread .github/workflows/_python-tests.yml Outdated
We want to test multi-cloud, multi-region without doubling CI wait times
or the overall sum of CPU consumed.  The fix is simple:  We already run
multiple Python versions, so run half of them on mcmr and half on the
classic tilt file.
@rescrv
rescrv force-pushed the rescrv/split-ci-for-mcmr branch from 49c3789 to 0616145 Compare February 3, 2026 21:41
@rescrv
rescrv changed the base branch from rescrv/test-add-mcmr to main February 3, 2026 21:41
@rescrv rescrv closed this Feb 18, 2026
@rescrv

rescrv commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

We did something different to test pre-merge on 3.9.

@rescrv
rescrv deleted the rescrv/split-ci-for-mcmr branch March 2, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants