Fix CI failure from unclosed warning file in build replay tests#4
Merged
chrizzFTD merged 1 commit intoJun 27, 2026
Conversation
The new Sphinx integration tests passed assertions but left the warnings.txt file handle open. With PYTHONWARNINGS=error in CI, pytest reports that as a ResourceWarning and exits with code 1. Co-authored-by: chrizzftd <chrizzFTD@users.noreply.github.com>
3 tasks
chrizzFTD
added a commit
that referenced
this pull request
Jun 27, 2026
Update vendored JS to chrizzFTD/pyrepl-web@5299fa9 on branch cursor/repl-startup-replay-2e3f. Picks up async Pygments restore and replay-src fetch error surfacing from pyrepl-web PR #4. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: chrizzftd <chrizzFTD@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
Vendor cursor/resolve-package-urls-0bbd@1d95c619, which is rebased onto grill with replay mode (#4) and relative wheel URL resolution. Restores replay-src runtime support that was lost in the earlier pre-rebase vendor. Co-authored-by: chrizzftd <chrizzFTD@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI run #7 failed even though all 5 tests passed. The failure came from
PYTHONWARNINGS=errorin the workflow treating an unclosed file handle as a fatal warning.The new tests in
tests/test_build_replay.py(added indba7f0f0) construct a Sphinx app with:That file is never closed. During pytest teardown, Python 3.14 emits a
ResourceWarning, which pytest promotes toPytestUnraisableExceptionWarningand causes a non-zero exit code.Fix
Wrap the Sphinx build in a
with open(...) as warning_file:block so the warnings file is closed before pytest finalizes.Verification
Ran locally with Python 3.14.6 and the same CI flags:
All 5 tests pass with exit code 0.