Fix Glama container build - #8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2ac6fa1e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .git | ||
| .github | ||
| .codex | ||
| .venv |
There was a problem hiding this comment.
Keep local environment secrets out of Docker builds
When this image is built from a developer checkout that has a gitignored .env with provider keys, COPY . . will still send it into the Docker context and bake it into /app, because this new ignore list only excludes .venv and not .env/.env.*. That undermines the container hardening goal and can leak credentials from local builds; please mirror the repo’s secret/environment ignores here.
Useful? React with 👍 / 👎.
What changed
Root cause
The Dockerfile ran
playwright install-depswithout a browser argument. With the current Playwright release this installed dependencies for Chromium, Firefox, and WebKit: 392 Debian packages and an approximately 2.27 GB uncompressed build layer. The resulting cold build took about 136 seconds locally and likely exceeded Glama's build time or image limits.Validation
244 passed in 133.57s5 passed in 0.31sfor release metadata after adding the regression teststart_sessionagainst Example Domain, andend_sessionNo provider credentials or environment files are included.