Remove static url configuration that improperly sets url path to a fi… - #206
Open
christabor wants to merge 4 commits into
Open
Remove static url configuration that improperly sets url path to a fi…#206christabor wants to merge 4 commits into
christabor wants to merge 4 commits into
Conversation
…le path, resulting in a 500 error in Windows. Closes #128.
…ings. Also add better linting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…le path, resulting in a 500 error in Windows. Closes #128.
Locally I'm able to confirm this works both during testing and in manual viewing of the page. I think this was originally set for the purpose of making it installable not just as an app, but as an imported package. However, the docs for flask indicate that this is always relative to the application, and this is configured to use an absolute path anyway:
STATIC_DIR = os.path.dirname(static.__file__)so, this should negate the need to manually set both.