fix(github-app-playground): bump chart to v0.11.1 / appVersion 1.8.0 - #30
Conversation
📝 WalkthroughWalkthroughThe Helm chart appVersion is bumped from 1.7.0 to 1.8.0, and the artifacthub.io/changes annotation is updated with corresponding release notes documenting the version change and feature updates. ChangesHelm Chart Version Bump
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly Related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
charts/github-app-playground/Chart.yaml (1)
20-26:⚠️ Potential issue | 🟠 Major | ⚡ Quick winBump chart
versionwhen changingappVersion.
appVersionwas updated to1.8.0, butversionis still0.11.0. Helm consumers rely on chartversionto detect/pull updates; without a chart version bump, this release may not propagate correctly.Suggested fix
-version: 0.11.0 +version: 0.12.0🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@charts/github-app-playground/Chart.yaml` around lines 20 - 26, Update the Helm chart metadata so the chart `version` is bumped to reflect the `appVersion` change: edit Chart.yaml and increment the top-level `version` field (e.g., from 0.11.0 to 0.11.1 or your repo's next chart version) to ensure Helm consumers detect the new release; ensure you only change the `version` field and leave `appVersion: "1.8.0"` intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/github-app-playground/Chart.yaml`:
- Line 50: The artifacthub.io/changes entry currently describes both v1.7.0 +
v1.8.0 and extra config keys which is broader than this PR; update the
Chart.yaml description (artifacthub.io/changes) to only mention the incremental
v1.8.0 changes introduced here — remove references to v1.7.0 and any keys not
added by this PR, and limit the text to the actual new features/config keys
added in this diff (adjust the description string under
description/artifacthub.io/changes and ensure it only lists the new v1.8.0
additions such as the PR-shepherding workflow and the exact config keys
introduced by this chart change).
---
Outside diff comments:
In `@charts/github-app-playground/Chart.yaml`:
- Around line 20-26: Update the Helm chart metadata so the chart `version` is
bumped to reflect the `appVersion` change: edit Chart.yaml and increment the
top-level `version` field (e.g., from 0.11.0 to 0.11.1 or your repo's next chart
version) to ensure Helm consumers detect the new release; ensure you only change
the `version` field and leave `appVersion: "1.8.0"` intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 46adfec2-ce4e-43a1-b486-4cb5aefbdf66
📒 Files selected for processing (1)
charts/github-app-playground/Chart.yaml
| artifacthub.io/changes: | | ||
| - kind: added | ||
| description: "Bumped appVersion to 1.7.0. Adds the upstream PR-shepherding (`bot:ship`) workflow: scoped commands, iteration loop, tickle scheduler, and four scoped executors. Exposes 8 new optional config keys mirroring src/config.ts: `botAppLogin` (group 5) and group 13 ship-loop tunables (`maxWallClockPerShipRun`, `maxShipIterations`, `cronTickleIntervalMs`, `mergeableNullBackoffMsList`, `reviewBarrierSafetyMarginMs`, `fixAttemptsPerSignatureCap`, `shipForbiddenTargetBranches`)." | ||
| description: "Bumped appVersion to 1.8.0 (covers upstream v1.7.0 + v1.8.0). Adds the upstream PR-shepherding (`bot:ship`) workflow: scoped commands, iteration loop, tickle scheduler, and four scoped executors. Exposes 8 new optional config keys mirroring src/config.ts: `botAppLogin` (group 5) and group 13 ship-loop tunables (`maxWallClockPerShipRun`, `maxShipIterations`, `cronTickleIntervalMs`, `mergeableNullBackoffMsList`, `reviewBarrierSafetyMarginMs`, `fixAttemptsPerSignatureCap`, `shipForbiddenTargetBranches`)." |
There was a problem hiding this comment.
Keep artifacthub.io/changes scoped to this release delta.
This entry describes v1.7.0 + v1.8.0 and new config keys, which appears broader than the actual chart diff in this PR. Consider narrowing it to only the incremental v1.8.0 changes to avoid misleading consumers.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@charts/github-app-playground/Chart.yaml` at line 50, The
artifacthub.io/changes entry currently describes both v1.7.0 + v1.8.0 and extra
config keys which is broader than this PR; update the Chart.yaml description
(artifacthub.io/changes) to only mention the incremental v1.8.0 changes
introduced here — remove references to v1.7.0 and any keys not added by this PR,
and limit the text to the actual new features/config keys added in this diff
(adjust the description string under description/artifacthub.io/changes and
ensure it only lists the new v1.8.0 additions such as the PR-shepherding
workflow and the exact config keys introduced by this chart change).
Summary
Bumps the
github-app-playgroundHelm chart to v0.11.1 andappVersionto v1.8.0 (upstream release).This is a code-only upstream release — no
.env.exampleorsrc/config.tschanges between v1.7.0 and v1.8.0. Chartversionis bumped patch (0.11.0 → 0.11.1) because the only delta isappVersion+ changelog; no chart-side surface change. (CI'schart-testingrequires every chart-modifying PR to bumpversion.)flowchart LR Old["Chart 0.11.0<br/>appVersion 1.7.0"]:::before Arrow["appVersion + patch bump<br/>no values/configmap deltas"]:::change New["Chart 0.11.1<br/>appVersion 1.8.0"]:::after Old --> Arrow --> New classDef before fill:#fff4e5,stroke:#cc6600,color:#1a1a1a classDef change fill:#e0e7ff,stroke:#3730a3,color:#1a1a1a classDef after fill:#d1fae5,stroke:#065f46,color:#1a1a1aChanges
Chart metadata
Chart.yaml:version 0.11.0 → 0.11.1(patch — no chart-surface change),appVersion "1.7.0" → "1.8.0"artifacthub.io/changes: appended three new entries reflecting upstream v1.8.0 (onechangedfor unified bot-reply format, twofixedfor logger/security redaction)Upstream v1.8.0 contents (informational)
err.*before pino emits (upstream #89, closes upstream fix(omniroute): correct appVersion to 3.8.48 to match published image #52)Verification
helm lint— cleanhelm template—app.kubernetes.io/version: "1.8.0"andhelm.sh/chart: github-app-playground-0.11.1rendered on all manifestsNotes