fix(workflow): fix release.yml - #98
Conversation
📝 WalkthroughWalkthroughThe PR adds ChangesRelease Workflow Permissions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the manual production release workflow to address the reusable Docker build workflow’s new attestation permission requirements. In the broader codebase, release.yml orchestrates CI, semantic-release, and the reusable docker-build.yml workflow for production releases.
Changes:
- Add
attestations: writeto the top-level permissions in.github/workflows/release.yml. - Keep the production release workflow aligned with the nested Docker image publish/attestation flow.
- Address the GitHub Actions validation failure reported for the production release workflow.
# [1.9.0](v1.8.0...v1.9.0) (2026-05-03) ### Bug Fixes * **checkout:** fetch PR base branch so origin/<baseBranch> resolves (closes [#74](#74)) ([#96](#96)) ([71f83a6](71f83a6)) * **fetcher:** paginate GraphQL connections + MAX_FETCHED_* caps (closes [#66](#66)) ([#95](#95)) ([f728ecd](f728ecd)) * **triage:** accept note-only evidence; raise research max-turns to 200 ([#97](#97)) ([3b6036c](3b6036c)) * **workflow:** fix release.yml ([#98](#98)) ([cb43d69](cb43d69)) ### Features * **workflows:** publish SLSA provenance + SBOM attestations on every release tag (closes [#58](#58)) ([#94](#94)) ([95856bc](95856bc))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
The
release.ymlworkflow was failing at startup with a GitHub Actions validation error. The reusabledocker-build.ymlworkflow requestsattestations: readat the workflow level andattestations: writein themergejob, but the callingdockerjob inrelease.ymlhad noattestationspermission declared — defaulting it tonone. GitHub blocks any nested workflow from elevating permissions beyond what the caller grants.Why
GitHub Actions enforces that
GITHUB_TOKENpermissions can only be maintained or reduced through a reusable workflow chain — never elevated. Grantingattestations: writeat the caller level satisfies both thereadandwritescopes required by the nesteddocker-build.ymljobs.Diagram
Changes
attestations: writeto the top-levelpermissionsblock in.github/workflows/release.ymlattestations: writeto the top-levelpermissionsblock in.github/workflows/dev-release.ymlRelated Issues
Test plan
Summary by CodeRabbit