Skip to content

fix(deps): pin transitive adm-zip to 0.6.0 for CVE-2026-39244 - #268

Merged
chrisleekr merged 1 commit into
mainfrom
fix/adm-zip-cve-2026-39244
Jul 18, 2026
Merged

fix(deps): pin transitive adm-zip to 0.6.0 for CVE-2026-39244#268
chrisleekr merged 1 commit into
mainfrom
fix/adm-zip-cve-2026-39244

Conversation

@chrisleekr

@chrisleekr chrisleekr commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Pins adm-zip to 0.6.0 via package.json overrides to close GHSA-xcpc-8h2w-3j85 (CVE-2026-39244, adm-zip DoS via crafted ZIP forcing unbounded Buffer.alloc), following the repo's established convention for transitive dependency pins (see existing picomatch, protobufjs overrides).

Why

The orchestrator Trivy scan job on the release-please pipeline (run 29626877176) failed on this CVE. The orchestrator image gates CI on CRITICAL/HIGH severities (the daemon image variant does not), so this was blocking the release pipeline.

adm-zip is a transitive dependency: @huggingface/transformers@4.2.0onnxruntime-node@1.24.3adm-zip@^0.5.16. GHSA-xcpc-8h2w-3j85 records firstPatched = 0.6.0 (vulnerable range <0.6.0). Trivy keys its npm advisory data on the GHSA, not NVD, so 0.5.18 (the NVD-listed fix) would not satisfy the gate; 0.6.0 is required. Because 0.6.0 is a major bump outside onnxruntime's ^0.5.16 range, it can't be resolved by bumping a direct dependency and is instead forced via overrides.

Safety

onnxruntime-node invokes adm-zip only from its install script (a single extractEntryTo on a file entry, read back at basename). adm-zip 0.6.0's only behavioral change (upstream #306) affects directory-entry handling, which this call path does not exercise. The dependency runs at install time only, never at runtime.

Verification

  • bun install resolves adm-zip@0.6.0 as the sole lockfile entry (no 0.5.17 remnant)
  • bun run typecheck passes
  • trivy fs against the updated tree reports 0 adm-zip vulnerabilities
flowchart LR
    HFT["@huggingface/transformers<br/>4.2.0"]:::keep --> ORT["onnxruntime-node<br/>1.24.3"]:::keep
    ORT -- "range ^0.5.16<br/>install-time only" --> OLD["adm-zip 0.5.17<br/>vulnerable<br/>GHSA-xcpc-8h2w-3j85"]:::bad
    OVR["package.json overrides<br/>adm-zip 0.6.0"]:::fix -. forces resolution .-> NEW["adm-zip 0.6.0<br/>patched"]:::good
    ORT -. "resolved dep after override" .-> NEW

    classDef keep fill:#2c3e50,color:#ffffff
    classDef bad fill:#c0392b,color:#ffffff
    classDef fix fill:#ecf0f1,color:#2c3e50
    classDef good fill:#27ae60,color:#ffffff
Loading

🤖 Generated with Claude Code

https://claude.ai/code/session_01TZqAX7ajr96SNFgQejP7fi

Summary by CodeRabbit

  • Chores
    • Updated dependency resolution to use adm-zip version 0.6.0.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@chrisleekr, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d1dbdd80-658a-4087-b0a1-c223c69c2960

📥 Commits

Reviewing files that changed from the base of the PR and between 9e6d753 and 2afb790.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • package.json
📝 Walkthrough

Walkthrough

package.json adds an adm-zip dependency resolution override pinned to version 0.6.0.

Changes

Dependency override

Layer / File(s) Summary
Pin adm-zip resolution
package.json
Adds an overrides entry pinning adm-zip to version 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: semantic-release-bot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: pinning transitive adm-zip to 0.6.0 to address the CVE.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

adm-zip is transitive via @huggingface/transformers -> onnxruntime-node
-> adm-zip@^0.5.16. The orchestrator Trivy scan gate (run 29626877176)
failed on CVE-2026-39244 (DoS via crafted ZIP forcing unbounded
Buffer.alloc). GHSA-xcpc-8h2w-3j85 records firstPatched=0.6.0, so the fix
is forced via overrides; 0.5.18 would not satisfy the GHSA-keyed gate.
Verified: trivy fs reports 0 adm-zip vulns; typecheck passes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01TZqAX7ajr96SNFgQejP7fi
@chrisleekr
chrisleekr force-pushed the fix/adm-zip-cve-2026-39244 branch from 9e6d753 to 2afb790 Compare July 18, 2026 03:33
@chrisleekr
chrisleekr merged commit a4db980 into main Jul 18, 2026
9 checks passed
@chrisleekr
chrisleekr deleted the fix/adm-zip-cve-2026-39244 branch July 18, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant