chore: add discover_explicit for vault plugin#20
Merged
Conversation
chrisguidry
approved these changes
Mar 10, 2026
parkedwards
force-pushed
the
ep/discover-explicit
branch
from
March 11, 2026 00:17
82d6323 to
994e7a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure about this one, but this PR adds
discover_explicit()to allow a plugin selection that returns a falsey object. specifically for the vault pluginran into this behavior that surprised me when i was adding docketeer-slack:
DOCKETEER_VAULTsetdocketeer startso the surprising behavior was that 1P was selected by default, and if no SA key is provided then the app crashes. this seems right for some single sub-systems (executor? and search maybe). unsure about vault though - id expect this to be unset, especially since it's an
optionalsystem. and then any key fetches would fail