fix: rm BOM from file content on read - #53
Merged
Conversation
Owner
|
Could you add some explanation and/or reference the issue number in the comment? Just so it's clear for future work why that line is necessary. Otherwise good to merge |
everdro1d
marked this pull request as draft
June 30, 2026 17:35
If a json file has utf-8 encoding vim.json.decode will fail due to the BOM at the start. This change removes the BOM from the file contents before attempting to decode. Resolves chrisgrieser#52.
everdro1d
marked this pull request as ready for review
June 30, 2026 17:48
chrisgrieser
approved these changes
Jun 30, 2026
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement
If a json file has utf-8 encoding,
vim.json.decodewill fail due to the BOM at the start. If package.json or snippet files are utf-8 encoded, it will fail to load. Resolves #52.Proposed solution
This change removes the BOM from the file contents before attempting to decode.
AI usage disclosure
None used.