This repository was archived by the owner on Apr 20, 2023. It is now read-only.
fix get_recent_comments on selenium/requests.Session (Fixes #124)#126
Closed
stefco wants to merge 1 commit into
Closed
fix get_recent_comments on selenium/requests.Session (Fixes #124)#126stefco wants to merge 1 commit into
stefco wants to merge 1 commit into
Conversation
Author
|
Moved this and several other suggested fixes to #125, easier to just track there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Post.get_recent_commentswould raise aKeyErrorwhen using Selenium or arequests.Sessionobject to scrape aPostdue to slight differences in the structure of the resultingjson_dict. I added anexceptblock to handle this and try the alternativejson_dictschema.Fixes #124
Checklist
Additional notes (optional)
Still need to write unit tests.