Skip to content

Fix EQ/reverb double-application and increase impulse reverb intensity - #277

Merged
cdrani merged 3 commits into
developfrom
fix/effect-double-application
Jan 7, 2026
Merged

Fix EQ/reverb double-application and increase impulse reverb intensity#277
cdrani merged 3 commits into
developfrom
fix/effect-double-application

Conversation

@cdrani

@cdrani cdrani commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix race condition causing EQ and reverb effects to be applied twice during audio chain initialization
  • Increase impulse reverb wet/dry mix intensity for more audible effects
  • Remove dead code and debug logs

Changes

Audio Effects Double-Application Fix

  • Remove REQUEST_EFFECT_REAPPLY postMessage dispatch that caused duplicate effect application
  • Fix disconnect() in AudioManager to cleanup effect chain before clearing references
  • Call setEffect() in processMediaPlayInit() to apply effects on first play
  • Remove dead REQUEST_EFFECT_REAPPLY listeners from effects, playback, volume, and ms-params stores

Impulse Reverb Intensity

  • Increase wet signal levels for more noticeable effects:
    • kick_ir: 5% → 50%
    • muffler_ir: 10% → 60%
    • diffusor_ir: 10% → 60%
    • telephone_ir: 35% → 70%

Cleanup

  • Remove debug console.log statements from reverb and ms-processor
  • Upgrade wxt to 0.19.29

Test plan

  • Toggle EQ presets and verify effects are applied once (no volume changes from double-application)
  • Enable reverb and verify it's applied correctly without distortion
  • Test impulse reverb presets (kick, muffler, diffusor, telephone) and verify they are audible
  • Verify effects are applied on first play
  • Verify effects persist across song changes

Charles Drani added 3 commits January 6, 2026 01:22
- Remove REQUEST_EFFECT_REAPPLY postMessage dispatch that caused duplicate
  effect application (once via message, once via processSongTransition)
- Fix disconnect() in AudioManager to cleanup effect chain before clearing
  references, ensuring effect nodes are properly disconnected
- Call setEffect() in processMediaPlayInit() to apply effects on first play
- Remove dead REQUEST_EFFECT_REAPPLY listeners from effects, playback,
  volume, and ms-params stores
Increase wet signal levels to make impulse reverb effects more audible:
- kick_ir: 5% → 50%
- muffler_ir: 10% → 60%
- diffusor_ir: 10% → 60%
- telephone_ir: 35% → 70%

Also remove debug console.log statements from reverb and ms-processor.
@cdrani
cdrani merged commit d220a00 into develop Jan 7, 2026
2 checks passed
@cdrani
cdrani deleted the fix/effect-double-application branch January 7, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant