Fix EQ/reverb double-application and increase impulse reverb intensity - #277
Merged
Conversation
added 3 commits
January 6, 2026 01:22
- Remove REQUEST_EFFECT_REAPPLY postMessage dispatch that caused duplicate effect application (once via message, once via processSongTransition) - Fix disconnect() in AudioManager to cleanup effect chain before clearing references, ensuring effect nodes are properly disconnected - Call setEffect() in processMediaPlayInit() to apply effects on first play - Remove dead REQUEST_EFFECT_REAPPLY listeners from effects, playback, volume, and ms-params stores
Increase wet signal levels to make impulse reverb effects more audible: - kick_ir: 5% → 50% - muffler_ir: 10% → 60% - diffusor_ir: 10% → 60% - telephone_ir: 35% → 70% Also remove debug console.log statements from reverb and ms-processor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Audio Effects Double-Application Fix
REQUEST_EFFECT_REAPPLYpostMessage dispatch that caused duplicate effect applicationdisconnect()in AudioManager to cleanup effect chain before clearing referencessetEffect()inprocessMediaPlayInit()to apply effects on first playREQUEST_EFFECT_REAPPLYlisteners from effects, playback, volume, and ms-params storesImpulse Reverb Intensity
Cleanup
Test plan