Skip to content

Fix impulse reverb audio chain and remove UI separators #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdrani merged 2 commits into from
Jan 4, 2026
Merged

Fix impulse reverb audio chain and remove UI separators #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c91108
🐛 fix: reconnect source node after cleanup in impulse reverb
Jan 4, 2026
3a2abfc
💄 style: remove vertical separators from FXEQ and Speed views
Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lib/audio-effects/audio-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,9 @@ export default class AudioManager {
// TODO: Refactor to support multi-effect with impulse reverb wet/dry
this.cleanupEffectChain()

// CRITICAL: Reconnect source to gain node after cleanup
this.source!.connect(this._gainNode!)

const dryGainNode = this._audioContext.createGain()
const wetGainNode = this._audioContext.createGain()

Expand Down
4 changes: 1 addition & 3 deletions src/lib/components/views/FXEQ.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
<script lang="ts">
import FX from '$lib/components/views/FX.svelte'
import EQ from '$lib/components/views/EQ.svelte'
import { Separator } from '$lib/components/ui/separator'

let { pip = false }: { pip?: boolean } = $props()
</script>

<div class="flex h-full w-full justify-center gap-x-2">
<div class="flex h-full w-full justify-center gap-x-2.5">
<FX {pip} />
<Separator orientation="vertical" class="h-full w-0.5" />
<EQ {pip} />
</div>
7 changes: 1 addition & 6 deletions src/lib/components/views/Speed.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
})
</script>

<div class="relative columns-2 gap-x-4 space-y-3">
<div class="columns-2 gap-x-2.5 space-y-3">
<div class="flex h-48 flex-col">
<PlaybackInput key="rate" list={$playbackStore.frequents.rate} />
<Separator orientation="horizontal" class="!my-2 h-0.5" />
Expand All @@ -51,11 +51,6 @@
</div>
</div>

<Separator
orientation="vertical"
class="absolute -top-2 left-1/2 h-48 w-0.5 -translate-x-1/2"
/>

<div class="flex h-48 flex-col">
<PlaybackInput key="pitch" list={$playbackStore.frequents.pitch} />
<Separator orientation="horizontal" class="!my-2 h-0.5" />
Expand Down