Conversation
The startup reset of stuck 'running' jobs was unscoped, so the catch-all background worker reverted webhook jobs the webhook worker had already claimed during the startup race, allowing double execution. Scope the reset to this worker's job partition (mirrors claim_next_job).
Only POST /instances/test disabled redirects; check_all_health, test_existing_instance, check_instance_health and the Plex library probe validated the URL with is_safe_url then followed redirects, so a 302 to a metadata/internal endpoint bypassed the block. Pass allow_redirects=False on all of them.
update_module_schedule(_blocks) persisted the raw string with no format check, so e.g. daily(2am) saved with a 200 but silently never fired. Add validate_schedule() (all frequencies) and return 400 on a malformed schedule.
… keys - FloatField rendered a stored 0 as an empty input (percentageValue || ''). - Resolving a duplicate group didn't invalidate the /media/duplicates list cache, so the group lingered. - Per-instance logs/libraries state keyed by bare name -> composite service:name keys like the other instance-state maps.
…top-left The CL2K/MM2K source tag on the recently-matched reel sat bottom-left; move it to the top-left.
Cover the worker reset partitioning, the instance-probe redirect opt-out, and schedule-string validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated back-merge of
mainintodevelop. Sync direction is main -> develop and shared files are byte-identical, so this should merge cleanly. Review and merge to bring main's changes (releases, fixes, dependency bumps) onto develop. Opened by the sync-develop workflow.