feat: implement Dmod_ReadDirEx in dmvfs SAL layer#54
Merged
Conversation
Closed
Agent-Logs-Url: https://github.com/choco-technologies/dmvfs/sessions/e9ad8f6f-438c-46e0-b50c-3719ac792254 Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
…ty docs Agent-Logs-Url: https://github.com/choco-technologies/dmvfs/sessions/e9ad8f6f-438c-46e0-b50c-3719ac792254 Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Dmod_ReadDirEx interface to SAL
feat: implement Dmod_ReadDirEx in dmvfs SAL layer
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dmod_ReadDirExwas declared indmod_sal.hand had a weak POSIX fallback in DMOD, but dmvfs never provided its own override — leaving the interface unsupported when using the dmvfs SAL.Changes
src/dmod_sal.c— Adds_ReadDirEximplementation that:dmvfs_readdirto retrieve the nextdmfsi_dir_entry_tDMFSI_ATTR_DIRECTORY→Dmod_DirEntryType_Dir, otherwiseDmod_DirEntryType_FileDmod_DirEntry_t(same lifetime contract as_ReadDir)g_last_dir_entry_namebuffer shared with_ReadDirg_last_dir_entryto file scope alongsideg_last_dir_entry_name, with unified thread-safety docs covering both functions