Fix path normalization to handle '.' and '..' components#46
Merged
Conversation
Add normalize_path function to resolve '.' (current directory) and '..' (parent directory) components in paths. This fixes the issue where 'ls' without arguments (which passes '.' to opendir) fails because the path is not properly normalized. Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
- Replace strtok with manual parsing to avoid string modification and improve thread safety - Calculate exact buffer size for normalized path to prevent potential buffer overflows - Use memcpy instead of strcat for safer string concatenation - Reduce memory allocation for components array Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix current directory listing issue with ls command
Fix path normalization to handle '.' and '..' components
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lswithout arguments (passing "." toopendir) fails becauseto_absolute_path()concatenates "." with the current directory, producing unnormalized paths like/mnt/.that filesystem implementations reject.Changes
Added
normalize_path(): Resolves "." and ".." components in absolute paths using a stack-based approachModified
to_absolute_path(): Now normalizes all paths before returningExample
All existing tests pass. CodeQL clean.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.