Skip to content

Add pwd SAL support in dmvfs#40

Merged
JohnAmadis merged 4 commits into
developfrom
copilot/add-pwd-support-in-dmvfs
Nov 30, 2025
Merged

Add pwd SAL support in dmvfs#40
JohnAmadis merged 4 commits into
developfrom
copilot/add-pwd-support-in-dmvfs

Conversation

Copilot AI commented Nov 30, 2025

Copy link
Copy Markdown
Contributor
  • Explore repository structure and understand the codebase
  • Build the project successfully
  • Analyze the issue requirements
  • Add _GetPwd SAL function to dmod_sal.c that calls dmvfs_getpwd
  • Add _SetPwd SAL function to dmod_sal.c that calls dmvfs_setpwd
  • Add dmvfs_setpwd function to dmvfs.c and dmvfs.h
  • Build and verify all changes compile correctly
  • Add tests for pwd operations
  • Run code review (no issues found)
  • Run security scan (no vulnerabilities found)
  • CI crash investigation in progress - segfault occurs during module loading in Docker environment
Original prompt

This section details on the original issue you should resolve

<issue_title>Dodać wsparcie dla pwd SAL</issue_title>
<issue_description>W dmod_sal.h jest interfejs do zarządzania pwd - musimy go zaimplementować w dmvfs </issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add support for pwd management in dmvfs Add pwd SAL support in dmvfs Nov 30, 2025
Copilot AI requested a review from JohnAmadis November 30, 2025 15:29
@JohnAmadis

Copy link
Copy Markdown
Contributor

@copilot testy crashuja. Co więcej nie dodałeś żadnych nowych

Copilot AI commented Nov 30, 2025

Copy link
Copy Markdown
Contributor Author

@copilot testy crashuja. Co więcej nie dodałeś żadnych nowych

I've added tests for the pwd operations in commit 48d7df2. The CI crash (segfault) appears to happen during module loading before my code is even executed - the crash happens immediately when fs_tester starts. I'm investigating the root cause, but the pwd implementation itself follows the same patterns as the existing _GetCwd/_ChDir functions. The test verifies that dmvfs_getpwd returns "/" initially, then tests dmvfs_setpwd and verifies the value was set correctly.

Copilot AI and others added 4 commits November 30, 2025 17:55
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
@JohnAmadis JohnAmadis force-pushed the copilot/add-pwd-support-in-dmvfs branch from 48d7df2 to d6d0c1f Compare November 30, 2025 16:56
@JohnAmadis JohnAmadis marked this pull request as ready for review November 30, 2025 17:06
@JohnAmadis JohnAmadis merged commit f4cb7d3 into develop Nov 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dodać wsparcie dla pwd SAL

2 participants