image saving feedback (#141)#154
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the image-save UX in the image details fullscreen preview by surfacing save feedback (banner + icon state), and refactors the model state from a boolean “saved” flag to a save counter so repeated saves can re-trigger feedback.
Changes:
- Add
savesCountplumbing intoZoomableImageScreenand show save feedback UI. - Refactor
ImageDetailsStatefromisImageSaved: BooltoimageSaveCount: Int(with a computedisImageSavedfor compatibility). - Make
SavedBannerreusable across screens by widening its access level.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Rewind/Screens/ImageDetails/ZoomableImageScreen.swift | Adds savesCount, shows a saved banner, and updates the save button icon based on save count. |
| Rewind/Screens/ImageDetails/ImageDetailsView.swift | Passes imageSaveCount into ZoomableImageScreen when presenting fullscreen preview. |
| Rewind/Screens/ImageDetails/ImageDetailsModel.swift | Replaces isImageSaved with imageSaveCount and increments on successful save; reintroduces isImageSaved as a derived property. |
| Rewind/Screens/Comparison/ComparisonScreen.swift | Makes SavedBanner non-private so it can be reused from other screens. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
27
to
31
|
|
||
| SavedBanner(savesCount: savesCount) | ||
|
|
||
| ZoomableImageView( | ||
| image: image, |
Comment on lines
161
to
164
| struct SavedBanner: View { | ||
| var savesCount: Int | ||
|
|
||
| var body: some View { |
RewindTests is a hosted target, so the app fully starts inside the test process: AppGraph builds the URLSession performer, CLLocationManager and remotes, and RootView forces a live RewindMapImpl with tile loading and annotation requests. All of it is @mainactor and competes with the tests for the main actor, which makes the timer-dependent MapModelTests blow their 2s eventually() deadline on CI. Pick the entry point instead of gating inside RewindApp, so the app type itself stays unaware of tests. Debug-only: tests always build Debug. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chizberg
force-pushed
the
saving-feedback
branch
from
July 19, 2026 19:20
e51a7f8 to
f2d8b21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.