feat(schedule): shared filter bottom sheet#205
Open
chiptus wants to merge 5 commits into
Open
Conversation
Timeline and ListSchedule each had their own inline day/time/stage filter predicates. Extract filterScheduleDays into src/lib/scheduleFilter.ts so both views share one pure, unit-tested implementation, and remove a stray debug console.log from ListSchedule in the process. Closes #190 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AziTqr3f12fxALYD6jhrW8
…ilter' into claude/188-195-filter-sheet
Move day/time/stage filters into a single ScheduleFilterSheet (shadcn bottom sheet) rendered by both Timeline and List views, replacing the List view's old inline expanding panel. The Filters trigger joins the Timeline toolbar row inline, with an active-filter count badge. Filter state stays shared URL state via useTimelineUrlState, applied through filterScheduleDays on both views; opening/applying/clearing filters never scrolls the viewport. Closes #195
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… into claude/188-195-filter-sheet
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AziTqr3f12fxALYD6jhrW8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves day/time/stage filters into one bottom sheet (
ScheduleFilterSheet) shared by both Schedule views, replacing the List view's old inline expanding panel. The Filters trigger now sits inline in the Timeline toolbar row, with an active-filter count badge.Stacked on #193's branch (day-jump toolbar) and also carries #190's commits (shared
filterScheduleDays, PR #198) until that merges — the filter-sheet work is the last commit on this branch.Verification
pnpm run lint,pnpm run typecheck,pnpm vitest runall pass.Closes #195
Generated by Claude Code