chore(schedule): remove orphaned nav/vote ui#199
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
Pull request overview
Removes unused schedule navigation/perspective UI and eliminates the dead view / votePerspective query parameters they were supporting, keeping schedule filtering behavior unchanged.
Changes:
- Deleted orphaned schedule timeline navigation components (
TimelineControls,TimelineNavigation) that were not rendered and contained no-op handlers. - Deleted the orphaned artists vote perspective selector UI (
VotePerspectiveSelector) tied to the rejectedgroupId=user.id“my votes” hack. - Removed the unused
viewandvotePerspectivesearch params from Zod search schemas and corresponding URL-state hooks.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/EditionView/tabs/ScheduleTab/TimelineNavigation.tsx | Deleted unused quick-nav + stage filter UI component. |
| src/pages/EditionView/tabs/ScheduleTab/TimelineControls.tsx | Deleted unused controls wrapper that exposed no-op jump handlers. |
| src/pages/EditionView/tabs/ArtistsTab/filters/VotePerspectiveSelector.tsx | Deleted unused vote perspective UI (rejected groupId=user.id approach). |
| src/lib/searchSchemas.ts | Removed votePerspective and schedule view search params from schemas/defaults. |
| src/hooks/useUrlState.ts | Stopped preserving votePerspective in URL state for sets routes. |
| src/hooks/useTimelineUrlState.ts | Removed view-related API and simplified filter clearing to drop all timeline search params. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the unrendered TimelineControls/TimelineNavigation (console.log-stub jump buttons) and VotePerspectiveSelector (rejected groupId=user.id hack), along with the dead
viewandvotePerspectivesearch params they existed for.Closes #189
Closes #154
Verification
pnpm run lint,pnpm run typecheck,pnpm vitest runall pass locally./festivals/:slug/editions/:slug/schedule/timelineand/schedule/listwithday/time/stagesquery params; filtering behaves exactly as before.Generated by Claude Code