Implement to_alpha_numeric_underscore_name for all StdLibType variants - #371
Open
finn-devs wants to merge 1 commit into
Open
Implement to_alpha_numeric_underscore_name for all StdLibType variants#371finn-devs wants to merge 1 commit into
finn-devs wants to merge 1 commit into
Conversation
The catch-all todo!() panicked when generating Swift code for bridge declarations using Option, Vec, RefSlice, Pointer, Str, U64, or I64 inside Result return types.
Author
|
Hi, I forked this repo and made these changes for my project, and thought others could find them useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
to_alpha_numeric_underscore_namemethod onStdLibTypehad a catch-all_ => todo!()arm that panicked at runtime when generating code forResultreturn types containing certain stdlib types (e.g.Result<Vec<u8>, String>).This replaces the catch-all with explicit implementations for the remaining variants:
U64→"U64"I64→"I64"Str→"Str"Vec→"Vec"Option→"Option"RefSlice→"RefSlice"Pointer→"Pointer"BoxedFnOnceis left as a labeledtodo!("BoxedFnOnce in alpha_numeric name")since I don't have a use case to test against.Changes:
crates/swift-bridge-ir/src/bridged_type.rs(+22 lines, -1 line)