You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please add a #[swift_bridge(Copy(4), Sendable)] type to crates/swift-integration-tests.
Can put documentation on the type explaining why we added the test type (i.e. basically that our codegen was missing a newline so adding this type ensures that our codegen is now working).
Don't have to call the type from the Swift side. Just defining it it crates/swift-integration-tests should be enough of a test case here.
Generally we don't land code without also adding a test that would have failed before the code was added.
Let me know if you'd like me to write up a guide on how to add this test.
Seems like you already have a good sense of where things are so I won't put effort into a guide unless you ask.
Also, same feedback as #339 (review) just need to update the PR title and body with more info (you can still also link to the issue #335 ).
After that this looks good. Thanks for the detailed report and for submitting a fix.
chinedufn
changed the title
FIXES #335
Fix using multiple Copy + Sendable types
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #335 by adding the missing newline