fix: the file-name preview tells the truth on every surface, and the run stops before the damage

[chhoumann]

Closes #1587. Closes #1588. Closes #1589. Closes #1590. Closes #1591. Closes #1594. Closes #1607.

The fourth round of the preview-truth cluster, after #1582 (#1563/#1564) and
#1595 (#1578/#1579/#1580), and the last one that was outstanding. One sentence:
every surface that previews a file name shows the name the run will produce,
and the run stops as soon as it knows it cannot produce one.

Six issues, three layers, all reproduced in this worktree's isolated vault
(Obsidian 1.13.0) before anything was written:

#	the preview said	the run did
#1587	Preview: File {{MVALUE}}	opened the math modal; the CLI listed mvalue as a required input
#1588	Preview: {{title}} note	ok:false - "{{title}} cannot be used in file names…"
#1589	Unresolved: {{VDATE:due}} + a red ":" error	ok:true, created Repro/2026-07-27.md
#1590	one-page form: fileName:Notes//Example Title, zero diagnostics	the builder showed Notes/Folder/Name/Example Title
#1591	(n/a)	ok:false after creating the folder and running the template's inline script
#1594	Unresolved: Bad: Example Title	everything had resolved

---

What was actually wrong

The pass lists had drifted from the run's (#1587, #1589)

{{MVALUE}} was left literal by both preview formatters, while
CompleteFormatter.format runs replaceMathValueInString and formatFileName
goes through format(). Both preview classes already overrode
promptForMathValue with a "calculation_result" stand-in that nothing could
reach - a dead override is the tell.

before	after

{{VDATE:due}} with no format previewed the raw token, while the run supplies
YYYY-MM-DD and creates the note. That token's own text contains a colon,
so #1595's illegal-character diagnostic was firing on it: a working format got
a red "a file or folder name cannot contain :" under a choice that creates
2026-07-27.md.

before	after

Rendering the date deletes that false accusation and lets the true one appear
where it belongs. Under |time the run's default is YYYY-MM-DD HH:mm, which
really does put a colon in the file name - so #1578's diagnostic now fires on
its own, with no new code:

before	after

Neither preview read an ANSWERED date either. The one-page input form seeds
the user's real picks into the formatter before computing the preview, and VDATE
was the only seeded requirement type ignored - so the row showed today's date
beside the date just chosen. Both formatters resolve a stored value through
renderStoredDateVariable, extracted from the run's own tail so there is one
implementation and not three.

A format that can never work looked fine (#1588)

formatFileName rejects {{title}} outright - the title is the file name -
and it checks twice: the raw format string, and format()'s output, where a
{{GLOBAL_VAR:}} snippet or a {{VALUE}} can smuggle one in. Both halves are
mirrored, on the same inputs.

before	after

The token keeps previewing literally rather than as an example title: it is
genuinely unresolved on screen, so "Unresolved:" is true, and the diagnostic is
what says it never will resolve.

The output-side check needed a correction first, or it would have turned a
working choice red. A {{title}} inside a spliced-in {{TEMPLATE:}} body
is not a failure: at run time that body goes through the child engine's
formatFileContent, which resolves the token before formatFileName sees the
name. The preview now does the same, at the include seam - not through the
shared token resolver, which would have invented "My Document Title" for an
unstored variable.

/\{\{title\}\}/i also stopped being copy-pasted: six inlined copies and the
new check all read TITLE_REGEX.

One label for two different problems (#1594)

before	after

The split already existed. #1582 added kind: "path" for the capture target's
hideWhen gate, defined as "the name came out fine, the vault will just not
accept it" - which is exactly the second class. Reusing that axis rather than
adding a parallel one keeps a single classification that cannot disagree with
itself. Unresolved wins when both are present: a missing template beside an
empty path segment is fundamentally a failure to resolve.

The run surface was the one place the message was worth most (#1590)

The one-page form previews the file name while you fill it in, using the same
formatter the builder uses - and wired up two fewer things.

Every diagnostic was discarded: computePreview returned
Record<string, string> and the modal rendered only those strings. Yet this is
the surface where the message matters most, because the user's real answers
are seeded in - so a title typed as Standup: Tuesday previews the exact name
that is about to fail:

before	after

setTargetFolderPath was never called, so Notes/{{FOLDER}}/x previewed
Notes//x plus an empty-segment error nobody could see:

It now resolves against the choice's folder when the run has already decided it,
and falls back to the builder's neutral placeholder otherwise. Deliberately
not the raw configured folder in every case: the run formats it first
(formatFolderPath) while setTargetFolderPath does not, so a folder of
Journal/{{DATE:YYYY-MM}} would splice the literal token into the name and -
since every argument-bearing token carries a colon - raise the
illegal-character error against a choice that works. The builder's row takes the
same folder, so the two surfaces agree.

Three more things surfaced while wiring it up: the row's key was the raw record
key (it read fileName:); the first pass ran before renderField populated
the value map, flashing a stand-in over prefilled answers; and updatePreviews
had no generation guard, though the 150ms debounce orders the starts of these
passes, not their completions. The empty tinted box reading "Preview" - rendered
for every Capture, Macro and Multi choice - is gone too.

The run found out far too late (#1591)

A name Obsidian refuses did not fail when the name was computed. It failed at
vault.create - by which point QuickAdd had created the target folder and
formatted the entire template body: real {{VALUE}} prompts, macros, and
inline js quickadd fences with their side effects.

Measured, with a template containing an inline script:

before: ok:false "Choice execution failed; no file was created."
        folderExists: true,  inlineScriptRuns: 1
after:  ok:false "Cannot create \"Repro1591Folder/Bad: My Note.md\": a file or
        folder name cannot contain \":\". Check your own text and tokens like
        {{TIME}}, which is HH:mm."
        folderExists: false, inlineScriptRuns: 0

The rule is reject only if the file does not already exist: : is legal on
macOS/Linux at the filesystem level, so a note made outside Obsidian can carry
one, and appending to it works today because nothing ever asks Obsidian to
accept the name. Each guard sits on a branch where non-existence is already
established, so none of them probes:

• TemplateEngine.createFileWithTemplate, first statement - its two production
  callers are the else of vault.adapter.exists and a freshly incremented
  collision name;
• CaptureChoiceEngine, gated character-for-character on the dispatch condition
  that routes to onCreateFileIfItDoesntExist, placed above the heading
  picker so the user is not asked to choose a heading for a note that cannot be
  created, and re-asserted at that sink;
• the "move note to match choice settings?" offer, which creates the target
  folder and then fails at renameFile. It declines quietly - the offer is an
  optional convenience, and the choice's own preview explains why.

Explicitly not inside normalizeGeneratedFilePath: CaptureChoiceEngine
calls that as an existence PROBE inside try/catch, where a new throw would
silently answer "does not exist".

#1607, found while fixing #1587 and folded in

RequirementCollector registers a requirement keyed mvalue, so the one-page
form asks for a "Math expression" and the CLI prints
missingFlags: ["value-mvalue=<value>"] - and nothing read either answer. The
form asked, then the run opened the modal on top of it; passing the CLI's own
recommended flag changed nothing. It was filed separately, then folded in here,
because #1587 asks to fix the abort message that names {{MATH}} (a token
QuickAdd has never had), and polishing the wording of unfollowable advice is
worse than leaving it alone. Read-only consumption, so {{MVALUE}} {{MVALUE}}
is still two questions.

before: value-mvalue=2+2*3 -> ok:false "…a value for a {{MATH}} expression was
                                        not provided up front."
after:  value-mvalue=2+2*3 -> ok:true, created "Repro/File 2+2*3.md"

---

Tradeoffs and things deliberately not done

The illegal-character set is unchanged. #1595 measured it: : and only
:. * ? " < > | ^ [ ] # and tab all create successfully on macOS/Linux.

The example date now snaps. #1595 deliberately left |startof:/|endof:
out of the file-name preview, on the grounds that snapping only that row would
split it from the body row. Both rows do it now, so that reason is gone - and
the alternative was an asymmetry ten lines wide, because the answered branch
beside it snaps (it runs the run's own renderer) and {{DATE:...|startof:month}}
in the same pass always has. Only a token that asks for a snap touches moment.

A half-typed |startof: unit no longer blanks the row, but is still
reported. An earlier draft of this branch swallowed the error with the throw;
that deleted a diagnostic the body preview already shipped and left a format
the run aborts on previewing as a finished date. The options and the error are
separate channels now: the text stays stable while you type, the complaint waits
for the 500ms idle gate the builder already has.

existsInVault mirrors captureTargetResolution rather than approximating
it. A draft required a TFile for the bare-name shape, which reddened a
working capture target - a bare extension-less name that is an existing folder
with no note beside it is a folder scope, and the picker writes to a file
inside it. Residual, unchanged from before this PR: a folder named exactly like
a Template choice's file-name format still excuses the warning. Telling the two
hosts apart needs the host to say which it is, and erring toward silence is this
cluster's rule - a wrong accusation is worse than a missing one.

The one-page preview withholds an untouched required {{VDATE:}}, because
submit() does: a required blank date is omitted so the sequential date prompt
still fires. Both paths go through one collectAnswers(), which lives on the
modal because the rule needs dateParseErrors, which only the modal has.

Filed rather than folded in: the <current folder> row that
TemplateChoiceEngine adds to the folder suggester, which can turn a
single-configured-folder run into a prompt (and, non-interactively, into an
abort). It is the reason likelyTargetFolderPath is likely and not known,
and fixing it changes run behaviour for people who rely on that row.

Validation

Everything below was measured in this worktree's isolated vault (Obsidian
1.13.0), against a build of this branch, after a full instance restart.

• All six issues reproduced first, then re-checked after each slice.
• [FEATURE] Refuse an impossible file name before running the template body #1591 side effects verified by counting inline-script executions and folder
  creations before and after.
• Back-compat verified with a Bad: Existing.md note written to disk outside
  Obsidian: the capture still appends to it, and its preview row stays quiet.
• Regression smoke: a plain Capture (create, then append), a plain Template, a
  {{VDATE:}} template with a supplied answer, and the capture-target and
  capture-format preview rows.
• pnpm run build, tsc -noEmit, svelte-check, eslint, and the full
  Vitest suite (4517 passing).

An adversarial review of the design ran before any code was written, and a
second one over the finished diff; both fed back in. Three of the new tests were
vacuous and were proved so by mutation - notably the capture guard's, which
passed with the guard deleted, and now asserts the heading picker never opened.

Summary by CodeRabbit

• Bug Fixes
  • Creatability checks now run earlier across template/file creation and move/rename flows, refusing invalid : targets before prompts, template reading, or folder creation.
  • Colon handling is consistent, including when the target resolves to an existing folder.
  • {{MVALUE}} / {{VDATE}} previews now correctly reuse already-collected values, apply default time/options, and follow snapping rules.
• User Interface
  • One-page preview labeling is now consistently “Unresolved / Won’t be created / Preview”, with improved layout spacing.
  • File-name previews better reflect the chosen destination folder context and stay coherent during fast preview updates.

[cloudflare-workers-and-pages]

Deploying quickadd with    Cloudflare Pages

Latest commit:	da6e01c
Status:	✅  Deploy successful!
Preview URL:	https://fabf3c2e.quickadd.pages.dev
Branch Preview URL:	https://chhoumann-1587-preview-name.quickadd.pages.dev

View logs

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ba9c0ed-6175-4467-8d2c-b4912dd412fb

📥 Commits

Reviewing files that changed from the base of the PR and between f6f0140 and da6e01c.

📒 Files selected for processing (31)

• src/engine/CaptureChoiceEngine.selection.test.ts
• src/engine/CaptureChoiceEngine.ts
• src/engine/TemplateEngine-1591-refuse-name.test.ts
• src/engine/TemplateEngine.ts
• src/engine/applyTemplateToActiveNote.test.ts
• src/engine/applyTemplateToActiveNote.ts
• src/engine/assertCreatableFilePath.test.ts
• src/engine/assertCreatableFilePath.ts
• src/formatters/completeFormatter.test.ts
• src/formatters/completeFormatter.ts
• src/formatters/fileNameDisplayFormatter-1578-illegal-chars.test.ts
• src/formatters/fileNameDisplayFormatter.audit-cleanup.test.ts
• src/formatters/fileNameDisplayFormatter.test.ts
• src/formatters/fileNameDisplayFormatter.ts
• src/formatters/formatDisplayFormatter-1587-mvalue.test.ts
• src/formatters/formatDisplayFormatter-1589-vdate.test.ts
• src/formatters/formatDisplayFormatter.ts
• src/formatters/formatter.ts
• src/formatters/helpers/snappedExampleDate.ts
• src/gui/ChoiceBuilder/TemplateChoiceForm.svelte
• src/gui/ChoiceBuilder/components/FormatPreviewField.svelte
• src/gui/ChoiceBuilder/components/FormatPreviewField.test.ts
• src/preflight/OnePageInputModal.test.ts
• src/preflight/OnePageInputModal.ts
• src/preflight/runOnePagePreflight.filenamePreview.test.ts
• src/preflight/runOnePagePreflight.ts
• src/styles.css
• src/utils/generatedFilePath.ts
• src/utils/previewTargetFolder.test.ts
• src/utils/previewTargetFolder.ts
• src/utils/vdateSyntax.ts

🚧 Files skipped from review as they are similar to previous changes (28)

• src/formatters/formatDisplayFormatter-1587-mvalue.test.ts
• src/gui/ChoiceBuilder/TemplateChoiceForm.svelte
• src/utils/previewTargetFolder.test.ts
• src/formatters/completeFormatter.test.ts
• src/engine/assertCreatableFilePath.test.ts
• src/engine/assertCreatableFilePath.ts
• src/utils/vdateSyntax.ts
• src/utils/previewTargetFolder.ts
• src/gui/ChoiceBuilder/components/FormatPreviewField.svelte
• src/formatters/helpers/snappedExampleDate.ts
• src/styles.css
• src/preflight/runOnePagePreflight.ts
• src/engine/applyTemplateToActiveNote.test.ts
• src/preflight/OnePageInputModal.test.ts
• src/formatters/formatDisplayFormatter-1589-vdate.test.ts
• src/engine/TemplateEngine.ts
• src/engine/CaptureChoiceEngine.ts
• src/utils/generatedFilePath.ts
• src/formatters/fileNameDisplayFormatter-1578-illegal-chars.test.ts
• src/preflight/runOnePagePreflight.filenamePreview.test.ts
• src/engine/TemplateEngine-1591-refuse-name.test.ts
• src/formatters/fileNameDisplayFormatter.test.ts
• src/engine/applyTemplateToActiveNote.ts
• src/formatters/formatDisplayFormatter.ts
• src/formatters/fileNameDisplayFormatter.audit-cleanup.test.ts
• src/formatters/completeFormatter.ts
• src/engine/CaptureChoiceEngine.selection.test.ts
• src/preflight/OnePageInputModal.ts

---

📝 Walkthrough

Walkthrough

The PR adds early illegal-path validation, aligns filename and body previews with runtime token behavior, and changes one-page previews to structured diagnostic rows with race-safe rendering and distinct unresolved versus non-creatable labels.

Changes

Preview and path validation

Layer / File(s)	Summary
Early generated-path validation src/engine/..., src/utils/generatedFilePath.ts, src/engine/*test.ts	Illegal path characters are rejected before template reading, prompt chains, folder creation, or rename operations, while existing-file handling remains supported.
Formatter preview parity src/formatters/..., src/utils/vdateSyntax.ts, src/utils/previewTargetFolder.ts	Previews resolve {{MVALUE}} and VDATE values, detect circular {{title}}, distinguish files from folders, and reuse collected values.
Structured preview rendering src/preflight/..., src/gui/ChoiceBuilder/..., src/styles.css	One-page previews return diagnostic rows, share answer collection with submission, prevent stale async updates, and distinguish “Unresolved” from “Won't be created.”

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

• chhoumann/quickadd#1017: Both modify adjacent template and capture file-creation flows.
• chhoumann/quickadd#1019: Both modify {{MVALUE}} handling in formatter.ts.
• chhoumann/quickadd#1560: Both modify preview diagnostics and labels.

Suggested labels: released

Poem

A rabbit checks each filename bright,
Before folders grow overnight.
Math and dates hop into view,
Diagnostics guide the preview too.
“Won’t be created” marks the snare—
Fresh rows bloom with careful care!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 70.59% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and clearly reflects the main change: fixing preview/runtime consistency and stopping invalid runs early.
Linked Issues check	✅ Passed	Issues [1587,1607], [1588,1589], [1590,1591,1594] are covered by the formatter, preflight, and engine changes.
Out of Scope Changes check	✅ Passed	All changes support the preview/runtime fix set or its tests; no clearly unrelated additions are present.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chhoumann/1587-preview-name-truth

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5db6d5dda8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/formatters/formatter.ts (1)

1465-1492: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Namespaced storage for {{MVALUE}} avoids clashing with {{VALUE:mvalue}}.

replaceMathValueInString reads this.variables.get("mvalue"), exactly the same bare key that {{VALUE:mvalue}} uses. FIELD variables avoid this with FIELD_VARIABLE_PREFIX, so a template containing both {{MVALUE}} and {{VALUE:mvalue}} shares one internal value. Use a dedicated internal key such as MVALUE_VARIABLE_KEY for {{MVALUE}} while keeping the user-facing requirement/CLI flag as "mvalue".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/formatters/formatter.ts` around lines 1465 - 1492, Use a dedicated
internal storage key such as MVALUE_VARIABLE_KEY in replaceMathValueInString
when reading the collected math answer, rather than the bare "mvalue" key used
by {{VALUE:mvalue}}. Keep the user-facing requirement name and CLI flag as
"mvalue", and update the corresponding MVALUE collection/storage path to use the
same namespaced key.

🧹 Nitpick comments (1)

src/preflight/OnePageInputModal.ts (1)

792-808: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Append diagnostics to rowEl, not the container.

Each row's issues are created on this.previewContainerEl while the value lives in rowEl, so a row and its problems are siblings rather than one grouped unit. It renders correctly today only because there is exactly one row and rows are appended in order; any second row (or row-level flex/grid styling) breaks the association, and assistive tech gets no structural link between a name and the reason it will be refused. The CSS selector .qa-onepage-preview .qa-preview-issue is a descendant match, so it keeps working.

♻️ Proposed change

 				for (const diagnostic of row.diagnostics) {
-					const issueEl = this.previewContainerEl.createDiv({
+					const issueEl = rowEl.createDiv({
 						cls: "qa-preview-issue",
 					});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/preflight/OnePageInputModal.ts` around lines 792 - 808, Change the
diagnostic rendering loop to append each `qa-preview-issue` element to the
current `rowEl` rather than `this.previewContainerEl`, keeping the existing
severity text, message, and title behavior unchanged so each row’s value and
issues remain grouped.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/engine/applyTemplateToActiveNote.ts`:
- Around line 330-335: Add regression coverage for the move flow around
isCreatableFilePath and the targetPath guard: use an illegal computed target,
then verify no prompt is shown and neither createFolder nor renameFile is
called. Keep the test focused on the declined move path and its existing
quiet-return behavior.

In `@src/engine/CaptureChoiceEngine.selection.test.ts`:
- Around line 1256-1285: Update the test around CaptureChoiceEngine.run to spy
on the executor or prompt path responsible for resolving the format’s {{VALUE}}
placeholder, then assert it is never called for the impossible “Bad: Title.md”
target. Keep the existing createFileWithInput assertion and verify both
prompting and file creation are skipped.

---

Outside diff comments:
In `@src/formatters/formatter.ts`:
- Around line 1465-1492: Use a dedicated internal storage key such as
MVALUE_VARIABLE_KEY in replaceMathValueInString when reading the collected math
answer, rather than the bare "mvalue" key used by {{VALUE:mvalue}}. Keep the
user-facing requirement name and CLI flag as "mvalue", and update the
corresponding MVALUE collection/storage path to use the same namespaced key.

---

Nitpick comments:
In `@src/preflight/OnePageInputModal.ts`:
- Around line 792-808: Change the diagnostic rendering loop to append each
`qa-preview-issue` element to the current `rowEl` rather than
`this.previewContainerEl`, keeping the existing severity text, message, and
title behavior unchanged so each row’s value and issues remain grouped.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0fb8dee9-2687-482a-af80-21d4bbe0dae8

📥 Commits

Reviewing files that changed from the base of the PR and between f9f158d and 5db6d5d.

📒 Files selected for processing (29)

• src/engine/CaptureChoiceEngine.selection.test.ts
• src/engine/CaptureChoiceEngine.ts
• src/engine/TemplateEngine-1591-refuse-name.test.ts
• src/engine/TemplateEngine.ts
• src/engine/applyTemplateToActiveNote.ts
• src/engine/assertCreatableFilePath.test.ts
• src/engine/assertCreatableFilePath.ts
• src/formatters/completeFormatter.test.ts
• src/formatters/completeFormatter.ts
• src/formatters/fileNameDisplayFormatter-1578-illegal-chars.test.ts
• src/formatters/fileNameDisplayFormatter.audit-cleanup.test.ts
• src/formatters/fileNameDisplayFormatter.test.ts
• src/formatters/fileNameDisplayFormatter.ts
• src/formatters/formatDisplayFormatter-1587-mvalue.test.ts
• src/formatters/formatDisplayFormatter-1589-vdate.test.ts
• src/formatters/formatDisplayFormatter.ts
• src/formatters/formatter.ts
• src/formatters/helpers/snappedExampleDate.ts
• src/gui/ChoiceBuilder/TemplateChoiceForm.svelte
• src/gui/ChoiceBuilder/components/FormatPreviewField.svelte
• src/gui/ChoiceBuilder/components/FormatPreviewField.test.ts
• src/preflight/OnePageInputModal.test.ts
• src/preflight/OnePageInputModal.ts
• src/preflight/runOnePagePreflight.filenamePreview.test.ts
• src/preflight/runOnePagePreflight.ts
• src/styles.css
• src/utils/generatedFilePath.ts
• src/utils/previewTargetFolder.ts
• src/utils/vdateSyntax.ts

[coderabbitai]

🧹 Nitpick comments (1)

src/engine/applyTemplateToActiveNote.test.ts (1)

537-541: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Dead ternary branch and stale comment in suggestMock mock.

typeof items[0] === "string" ? items[0] : items[0] returns items[0] regardless of the condition — the branch is dead code. The comment "First call picks the template, second picks the insert mode" also contradicts the earlier comment (Lines 506-508) stating the mode picker is skipped for this empty-note test, since only the template picker actually runs here.

🧹 Proposed cleanup

 		suggestMock.mockImplementation(async (_app, _labels, values) => {
-			const items = values as Array<unknown>;
-			// First call picks the template, second picks the insert mode.
-			return typeof items[0] === "string" ? items[0] : items[0];
+			const items = values as Array<unknown>;
+			// Only the template picker runs here; the empty-note fast path
+			// skips the insert-mode picker (see makeApp above).
+			return items[0];
 		});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/engine/applyTemplateToActiveNote.test.ts` around lines 537 - 541, Clean
up the suggestMock implementation by returning items[0] directly without the
redundant ternary. Remove or update the comment above it so it accurately
reflects that this empty-note test invokes only the template picker, not an
insert-mode picker.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/engine/applyTemplateToActiveNote.test.ts`:
- Around line 537-541: Clean up the suggestMock implementation by returning
items[0] directly without the redundant ternary. Remove or update the comment
above it so it accurately reflects that this empty-note test invokes only the
template picker, not an insert-mode picker.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ad421fdf-bbc7-46a1-aa85-6889eeb343e5

📥 Commits

Reviewing files that changed from the base of the PR and between 232d191 and 970cbb5.

📒 Files selected for processing (4)

• src/engine/CaptureChoiceEngine.selection.test.ts
• src/engine/applyTemplateToActiveNote.test.ts
• src/utils/previewTargetFolder.test.ts
• src/utils/previewTargetFolder.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• src/utils/previewTargetFolder.ts
• src/engine/CaptureChoiceEngine.selection.test.ts

[chhoumann]

Re-verified end to end against 970cbb56 in this worktree's isolated vault (Obsidian 1.13.0), after a full instance restart, since three rounds of review feedback landed after the original run:

builder, file name format
  File {{MVALUE}}          -> Preview: File calculation_result
  {{title}} note           -> Unresolved: {{title}} note        + circular-dependency error
  {{VDATE:due}}            -> Preview: 2026-07-27               + no diagnostics   (the false ':' is gone)
  {{VDATE:due|time}}       -> Won't be created: 2026-07-27 19:30 + ':' error        (the true one appears)
  Bad: {{VALUE:title}}     -> Won't be created: Bad: Example Title

one-page form, title typed as "Standup: Tuesday"
  Won't be created: Notes/Repro/Standup: Tuesday
  A file or folder name cannot contain ":", so this choice would fail at run time. ...

run, Template choice whose template contains an inline js quickadd fence
  ok:false  Cannot create "Repro1591Folder/Bad: My Note.md": a file or folder name
            cannot contain ":". Check your own text and tokens like {{TIME}}, which is HH:mm.
  folderExists: false   inlineScriptRuns: 0        (before: true / 1)

Also still passing: a Capture that creates then appends, a plain Template, a {{VDATE:}} template run with a supplied answer, value-mvalue= on the CLI, and — the back-compat case the colon carve-out exists for — appending to a Bad: Existing.md note written to disk outside Obsidian, whose preview row stays quiet.

Full suite green under TZ=UTC and TZ=America/Los_Angeles (the TZ-dependent assertion CI caught is fixed and re-checked from UTC-8 through UTC+14).

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/formatters/fileNameDisplayFormatter.ts (1)

675-688: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Stale doc comment above now contradicts the code. The block comment at Lines 638-641 still states this preview renders the date without applying |startof:/|endof: snap, while the new example branch snaps via snappedExampleDate(snap) and the inline comment at Lines 675-683 explains why. Worth dropping the outdated sentences so the two comments don't disagree.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/formatters/fileNameDisplayFormatter.ts` around lines 675 - 688, Update
the stale documentation comment above the preview example branch to remove
statements claiming the date is rendered without applying startof/endof
snapping. Keep the current behavior in DateFormatPreviewGenerator.generate and
snappedExampleDate(snap) unchanged, and retain only wording consistent with the
snapping implementation.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/gui/ChoiceBuilder/components/FormatPreviewField.svelte`:
- Around line 113-115: Update the diagnostics flow surrounding the derived
values errors, isUnresolved, and isInvalid so changing value or targetFolderPath
cannot reuse errors from the prior value while the delayed async formatting pass
is pending. Clear diagnostics or gate reads using the latest completed pass,
while preserving previewToken commit protection, and add a regression test
covering a delayed format beyond the 500 ms idle delay.

---

Nitpick comments:
In `@src/formatters/fileNameDisplayFormatter.ts`:
- Around line 675-688: Update the stale documentation comment above the preview
example branch to remove statements claiming the date is rendered without
applying startof/endof snapping. Keep the current behavior in
DateFormatPreviewGenerator.generate and snappedExampleDate(snap) unchanged, and
retain only wording consistent with the snapping implementation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6309a3b0-3757-46f2-8af4-1b49650464c6

📥 Commits

Reviewing files that changed from the base of the PR and between 970cbb5 and f6f0140.

📒 Files selected for processing (31)

• src/engine/CaptureChoiceEngine.selection.test.ts
• src/engine/CaptureChoiceEngine.ts
• src/engine/TemplateEngine-1591-refuse-name.test.ts
• src/engine/TemplateEngine.ts
• src/engine/applyTemplateToActiveNote.test.ts
• src/engine/applyTemplateToActiveNote.ts
• src/engine/assertCreatableFilePath.test.ts
• src/engine/assertCreatableFilePath.ts
• src/formatters/completeFormatter.test.ts
• src/formatters/completeFormatter.ts
• src/formatters/fileNameDisplayFormatter-1578-illegal-chars.test.ts
• src/formatters/fileNameDisplayFormatter.audit-cleanup.test.ts
• src/formatters/fileNameDisplayFormatter.test.ts
• src/formatters/fileNameDisplayFormatter.ts
• src/formatters/formatDisplayFormatter-1587-mvalue.test.ts
• src/formatters/formatDisplayFormatter-1589-vdate.test.ts
• src/formatters/formatDisplayFormatter.ts
• src/formatters/formatter.ts
• src/formatters/helpers/snappedExampleDate.ts
• src/gui/ChoiceBuilder/TemplateChoiceForm.svelte
• src/gui/ChoiceBuilder/components/FormatPreviewField.svelte
• src/gui/ChoiceBuilder/components/FormatPreviewField.test.ts
• src/preflight/OnePageInputModal.test.ts
• src/preflight/OnePageInputModal.ts
• src/preflight/runOnePagePreflight.filenamePreview.test.ts
• src/preflight/runOnePagePreflight.ts
• src/styles.css
• src/utils/generatedFilePath.ts
• src/utils/previewTargetFolder.test.ts
• src/utils/previewTargetFolder.ts
• src/utils/vdateSyntax.ts

🚧 Files skipped from review as they are similar to previous changes (28)

• src/formatters/helpers/snappedExampleDate.ts
• src/gui/ChoiceBuilder/TemplateChoiceForm.svelte
• src/engine/assertCreatableFilePath.test.ts
• src/utils/previewTargetFolder.ts
• src/formatters/formatDisplayFormatter-1587-mvalue.test.ts
• src/utils/vdateSyntax.ts
• src/utils/previewTargetFolder.test.ts
• src/utils/generatedFilePath.ts
• src/engine/CaptureChoiceEngine.ts
• src/engine/TemplateEngine.ts
• src/engine/assertCreatableFilePath.ts
• src/gui/ChoiceBuilder/components/FormatPreviewField.test.ts
• src/preflight/runOnePagePreflight.ts
• src/formatters/completeFormatter.test.ts
• src/engine/applyTemplateToActiveNote.ts
• src/formatters/formatDisplayFormatter-1589-vdate.test.ts
• src/preflight/OnePageInputModal.test.ts
• src/engine/CaptureChoiceEngine.selection.test.ts
• src/engine/TemplateEngine-1591-refuse-name.test.ts
• src/styles.css
• src/preflight/OnePageInputModal.ts
• src/preflight/runOnePagePreflight.filenamePreview.test.ts
• src/formatters/fileNameDisplayFormatter-1578-illegal-chars.test.ts
• src/engine/applyTemplateToActiveNote.test.ts
• src/formatters/completeFormatter.ts
• src/formatters/formatDisplayFormatter.ts
• src/formatters/fileNameDisplayFormatter.test.ts
• src/formatters/fileNameDisplayFormatter.audit-cleanup.test.ts

[chhoumann]

Verified the {{MVALUE}} half of this PR (Closes #1607) end-to-end on the merged commit, in an isolated Obsidian 1.13.0 e2e vault, against the exact repro from #1607.

Fixture: a Template choice whose file name format is File {{MVALUE}}.

Before (master @ bcc0f0a) — the CLI advertised a flag it then refused:

$ quickadd:run choice=ReproMath verify=true
{"ok":false,"error":"Missing required inputs for non-interactive CLI run.",
 "missing":[{"id":"mvalue","label":"Math expression",...}],"missingFlags":["value-mvalue=<value>"]}

$ quickadd:run choice=ReproMath value-mvalue=2+2*3 verify=true
{"ok":false,"error":"This run is non-interactive but a value for a {{MATH}} expression was not
 provided up front...","aborted":true}

After (this branch) — the advertised flag works, and the copy no longer names a token QuickAdd does not have:

$ quickadd:run choice=ReproMath value-mvalue=2+2*3 verify=true
{"ok":true,"choice":{"name":"ReproMath","type":"Template"},"file":"File 2+2*3.md","verified":true,"durationMs":11}

The read-first-never-write shape holds up: a single collected answer fills every occurrence (the collector registers exactly one requirement for the token), and an uncollected run keeps the per-occurrence prompt it has always had.

One residual, noted rather than filed — it is arguably correct behaviour: an explicitly empty value (value-mvalue= or value-mvalue=' ') passes the preflight's missing-inputs gate but is then rejected by the run, which reports This run is non-interactive but a value for a {{MVALUE}} math expression was not provided up front. An empty math expression cannot produce a name, so aborting is right and the message is now accurate; only the two gates disagree about whether "provided but empty" counts as provided.

Context: I own #1614/#1615 on chhoumann/1607-interactive-parity and had #1607 in my brief. Since this PR already closes it, I dropped it from my diff rather than duplicating the fix.