Skip to content

fix(parser): read fields inside Admonition blocks - #189

Merged
chhoumann merged 2 commits into
masterfrom
188-bug-api-getpropertyvalue-for-dataview-field-in-ad-note-block
Jul 13, 2026
Merged

fix(parser): read fields inside Admonition blocks#189
chhoumann merged 2 commits into
masterfrom
188-bug-api-getpropertyvalue-for-dataview-field-in-ad-note-block

Conversation

@chhoumann

@chhoumann chhoumann commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

Restore MetaEdit's established support for Dataview inline fields inside Admonition ad-* fenced blocks. Ordinary fenced code blocks remain excluded so code examples are not exposed as metadata.

Changes

  • Preserve each opening fence's info string and classify ad-* fences as readable metadata containers.
  • Preserve ordinary code fences nested inside Admonitions as hidden code examples.
  • Apply the classification through the shared parser walk, keeping reads, updates, and inline-field insertion consistent.
  • Add parser, controller, insertion, and live public-API regressions based on the issue sample.

Testing / validation

  • pnpm run lint
  • pnpm run build
  • pnpm run test - 359 tests passed
  • Live Obsidian E2E regression passed in the isolated metaedit-metaedit vault on Obsidian 1.13.0 (installer 1.12.7): Admonition fields were read, Id was updated and read back, top-level and nested js fences remained hidden and unchanged, and dev:errors was empty.
  • Two complete E2E runs encountered unrelated, non-deterministic modal-harness timeouts in existing tests. The new regression passed independently, and every affected existing test file passed when rerun independently.

Release / migration impact

Patch-level bug fix. No settings, stored-data, or public API shape migration is required. No visible UI change, so screenshots are not applicable.

Checklist

  • PR title follows Conventional Commits - it becomes the squash-merge commit and drives the released version.
  • Linked the related issue.
  • Noted release and migration impact.

Fixes #188

@chhoumann chhoumann linked an issue Jul 13, 2026 that may be closed by this pull request
@chhoumann
chhoumann marked this pull request as ready for review July 13, 2026 12:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c06ca6a0bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/parser.ts Outdated
@chhoumann
chhoumann merged commit d337468 into master Jul 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] API getPropertyValue for dataview field in ad-note block

1 participant