Potential fix for code scanning alert no. 3: Prototype-polluting assignment - #26
Closed
BilgeGates wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 3: Prototype-polluting assignment#26BilgeGates wants to merge 1 commit into
BilgeGates wants to merge 1 commit into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
github-actions
Bot
added
needs-triage
area: board-utils
BilgeGates
marked this pull request as ready for review
July 15, 2026 18:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General fix: enforce strict runtime validation of computed indices before any property access/assignment, so only safe integer indices
0..7are ever used. This prevents special keys (__proto__,constructor,prototype) and other non-integer/coerced values from reaching assignment sinks.Best fix here (without changing functionality): strengthen
resolveinsrc/board.tsto reject non-integer numeric tuple values usingNumber.isIntegerbefore range checks. This keeps existing API/behavior for valid inputs (strings resolved bysquareToIndices, or numeric tuples) while closing prototype-pollution-style dynamic key abuse paths. No new imports or dependencies are required.