Update to latest Bitbucket API; simplify validation; add logging and helpful response - #9
Update to latest Bitbucket API; simplify validation; add logging and helpful response#9matmar10 wants to merge 4 commits into
Conversation
…arly format; use express-validator to simplify body validation
|
This looks good. However, you have a mix of tabs/space indentation. The project should be done in |
|
I've improved some of the logging functionality in #10, along with adding code style verification and updating outdated deps. Feel free to apply your additional parameter verifications on top of the latest of |
|
I wish you'd just copied and replaced spaces with tabs before your latest pull request. Now there are lots and lots of merge conflicts now. I feel like my work was wasted :-P Regarding "code style verification" I see your tabs4life but it seems it lacks a style guide? Can you provide a |
|
Ah crap, you're right. I should have merged this in first. Sorry. I can apply your express validate additions later if you don't have the time. Just let me know. I will look into editor integration with tabs4life as well. |
|
Not sure if you saw, but bit bucket recently released native build status integration. Although I don't think Codeship has updated to support it yet. https://blog.bitbucket.org/2015/11/18/introducing-the-build-status-api-for-bitbucket-cloud/ |
|
No worries. Actually JSBeautify has a grunt plugin that would work well for this purpose (no IDE integration needed). One of the build steps would format according to your guideline. Here's an example of how it can be done: https://github.com/matmar10/grunt-env-config-to-file/blob/master/Gruntfile.js Need your tweaks to make this work, but this is the general idea for a |
|
I've also been looking at http://eslint.org as well which has a similar In the meantime, you can run |
No description provided.