Make test_http_over_https_error compatible with Solaris - #776
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 79.36% 79.15% -0.21%
==========================================
Files 29 29
Lines 4201 4203 +2
Branches 538 539 +1
==========================================
- Hits 3334 3327 -7
- Misses 723 730 +7
- Partials 144 146 +2 |
mtelka
force-pushed
the
test_http_over_https_error
branch
from
September 30, 2025 18:20
3cb54b1 to
a55f1a3
Compare
webknjaz
enabled auto-merge (squash)
October 3, 2025 13:29
webknjaz
disabled auto-merge
October 3, 2025 13:29
webknjaz
enabled auto-merge
October 3, 2025 13:30
webknjaz
disabled auto-merge
October 3, 2025 13:30
Member
|
@mtelka could you add a contrib change note, though? |
mtelka
force-pushed
the
test_http_over_https_error
branch
from
October 3, 2025 22:28
a55f1a3 to
44c60e6
Compare
Contributor
Author
Done. |
webknjaz
reviewed
Oct 3, 2025
webknjaz
reviewed
Oct 5, 2025
test_http_over_https_error compatible with Solaris
webknjaz
added a commit
to mtelka/cheroot
that referenced
this pull request
Oct 14, 2025
webknjaz
added a commit
to mtelka/cheroot
that referenced
this pull request
Oct 14, 2025
webknjaz
enabled auto-merge
October 14, 2025 19:59
Member
|
@mtelka could you rebase w/ conflict resolution? |
The test was missing Solaris support and so it was failing.
auto-merge was automatically disabled
October 15, 2025 21:35
Head branch was pushed to by a user without write access
mtelka
force-pushed
the
test_http_over_https_error
branch
from
October 15, 2025 21:35
454caff to
059c338
Compare
Contributor
Author
Done |
webknjaz
reviewed
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)I had to do this to make the
test_http_over_https_errortest passing on illumos (a Solaris fork).❓ What is the current behavior? (You can also link to an open issue here)
The test fails when running on illumos.
❓ What is the new behavior (if this is a feature change)?
The test passes.
📋 Other information:
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is