Skip to content

Make test_http_over_https_error compatible with Solaris - #776

Merged
webknjaz merged 2 commits into
cherrypy:mainfrom
mtelka:test_http_over_https_error
Oct 16, 2025
Merged

Make test_http_over_https_error compatible with Solaris#776
webknjaz merged 2 commits into
cherrypy:mainfrom
mtelka:test_http_over_https_error

Conversation

@mtelka

@mtelka mtelka commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

📋 What is the related issue number (starting with #)

I had to do this to make the test_http_over_https_error test passing on illumos (a Solaris fork).

What is the current behavior? (You can also link to an open issue here)

The test fails when running on illumos.

What is the new behavior (if this is a feature change)?

The test passes.

📋 Other information:

📋 Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@codecov

codecov Bot commented Sep 30, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.15%. Comparing base (094088f) to head (3538e73).
⚠️ Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   79.36%   79.15%   -0.21%     
==========================================
  Files          29       29              
  Lines        4201     4203       +2     
  Branches      538      539       +1     
==========================================
- Hits         3334     3327       -7     
- Misses        723      730       +7     
- Partials      144      146       +2     

@mtelka
mtelka force-pushed the test_http_over_https_error branch from 3cb54b1 to a55f1a3 Compare September 30, 2025 18:20

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz
webknjaz enabled auto-merge (squash) October 3, 2025 13:29
@webknjaz
webknjaz disabled auto-merge October 3, 2025 13:29
@webknjaz
webknjaz enabled auto-merge October 3, 2025 13:30
@webknjaz
webknjaz disabled auto-merge October 3, 2025 13:30
@webknjaz

webknjaz commented Oct 3, 2025

Copy link
Copy Markdown
Member

@mtelka could you add a contrib change note, though?

@mtelka
mtelka force-pushed the test_http_over_https_error branch from a55f1a3 to 44c60e6 Compare October 3, 2025 22:28
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided A mark meaning that a new change log entry is present within the patch. label Oct 3, 2025
@mtelka

mtelka commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

@mtelka could you add a contrib change note, though?

Done.

Comment thread docs/changelog-fragments.d/776.bugfix.rst Outdated
Comment thread docs/changelog-fragments.d/776.contrib.rst
@webknjaz webknjaz changed the title Fix test_http_over_https_error on Solaris Make test_http_over_https_error compatible with Solaris Oct 5, 2025
webknjaz added a commit to mtelka/cheroot that referenced this pull request Oct 14, 2025
webknjaz added a commit to mtelka/cheroot that referenced this pull request Oct 14, 2025
@webknjaz
webknjaz enabled auto-merge October 14, 2025 19:59
@webknjaz

Copy link
Copy Markdown
Member

@mtelka could you rebase w/ conflict resolution?

The test was missing Solaris support and so it was failing.
auto-merge was automatically disabled October 15, 2025 21:35

Head branch was pushed to by a user without write access

@mtelka
mtelka force-pushed the test_http_over_https_error branch from 454caff to 059c338 Compare October 15, 2025 21:35
@mtelka

mtelka commented Oct 15, 2025

Copy link
Copy Markdown
Contributor Author

@mtelka could you rebase w/ conflict resolution?

Done

Comment thread cheroot/test/test_ssl.py Outdated
@webknjaz webknjaz closed this Oct 16, 2025
@webknjaz webknjaz reopened this Oct 16, 2025
@webknjaz
webknjaz enabled auto-merge October 16, 2025 12:37
@webknjaz
webknjaz merged commit 630521a into cherrypy:main Oct 16, 2025
69 of 76 checks passed
@mtelka
mtelka deleted the test_http_over_https_error branch October 16, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided A mark meaning that a new change log entry is present within the patch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants