feat: hide labels of overlapping peaks - #3749
Merged
Merged
Conversation
Deploying nmrium with
|
| Latest commit: |
36c60c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c7196f2.nmrium.pages.dev |
| Branch Preview URL: | https://hide-peaks-that-overlap-peak.nmrium.pages.dev |
hamed-musallam
force-pushed
the
hide-peaks-that-overlap-peaks
branch
from
October 9, 2025 12:22
002c303 to
c1bd31b
Compare
targos
reviewed
Oct 9, 2025
hamed-musallam
force-pushed
the
hide-peaks-that-overlap-peaks
branch
from
October 9, 2025 12:26
c1bd31b to
ca75a5a
Compare
…mentation chore: remove unused context return from useTextMetrics
hamed-musallam
force-pushed
the
hide-peaks-that-overlap-peaks
branch
from
October 9, 2025 12:30
ca75a5a to
dd7b1c9
Compare
Member
|
It is not what I would expect because on cytisine autorange picking we don't have the value of the highest peak. In case of many peaks overlapping the more intense (if Y > 0 the highest, if Y < 0 the lowest) should be displayed. If you look at the gif we see that some peaks are not displayed while there is in fact enough room.
|
lpatiny
approved these changes
Oct 10, 2025
lpatiny
left a comment
lpatiny
left a comment
Member
There was a problem hiding this comment.
It works as I expected, thanks !
Reduce the line height for overlapped peaks to improve readability close #3714 feat: improve peaks overlap detection
hamed-musallam
force-pushed
the
hide-peaks-that-overlap-peaks
branch
from
October 10, 2025 10:53
9c483fb to
36c60c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.