Skip to content

chore: update @zakodium/nmr-types and move them to dev dependencies - #3732

Closed
stropitek wants to merge 1 commit into
mainfrom
update-nmr-types
Closed

chore: update @zakodium/nmr-types and move them to dev dependencies#3732
stropitek wants to merge 1 commit into
mainfrom
update-nmr-types

Conversation

@stropitek

Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: d059c00
Status: ✅  Deploy successful!
Preview URL: https://b2c63067.nmrium.pages.dev
Branch Preview URL: https://update-nmr-types.nmrium.pages.dev

View logs

@targos

targos commented Oct 2, 2025

Copy link
Copy Markdown
Member

Don't you want to update the core deps with it?

@stropitek

Copy link
Copy Markdown
Contributor Author

Don't you want to update the core deps with it?

It breaks the types and I think it should be handled by #3677

@stropitek

Copy link
Copy Markdown
Contributor Author

It breaks the type in a way that forces me to define default workspace settings for the feature that PR is related to.

@targos

targos commented Oct 2, 2025

Copy link
Copy Markdown
Member

We should probably move the generation of the default settings to the core. It shouldn't be a breaking change to add new fields.

@stropitek

Copy link
Copy Markdown
Contributor Author

I'm closing this because I realized those types should be in production dependencies.

The NMRium package exports types which depend on the @zakodium/nmr-types package.

For example:

CleanShot 2025-10-03 at 10 32 05@2x

NMRiumData is exported from the package and it depends on Spectrum which itself depends on Info1D which comes from nmr-types.

@stropitek stropitek closed this Oct 3, 2025
@targos
targos deleted the update-nmr-types branch October 3, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants