Skip to content

fix: correctly assign both x and y axes in 2D - #3729

Merged
hamed-musallam merged 1 commit into
mainfrom
fix-assignment-axis
Oct 2, 2025
Merged

fix: correctly assign both x and y axes in 2D#3729
hamed-musallam merged 1 commit into
mainfrom
fix-assignment-axis

Conversation

@hamed-musallam

Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: c395ab9
Status: ✅  Deploy successful!
Preview URL: https://9e93d227.nmrium.pages.dev
Branch Preview URL: https://fix-assignment-axis.nmrium.pages.dev

View logs

@lpatiny

lpatiny commented Oct 1, 2025

Copy link
Copy Markdown
Member

Works correctly thanks.

Concerning the padding of the highlight is the issue in this project or in react-ocl-nmr ?

image

@hamed-musallam

Copy link
Copy Markdown
Member Author

We have to address this issue in react-ocl-nmr because when we set the width to OCLnmr, it does not take into account the circle radius, which appears over the atom

@hamed-musallam
hamed-musallam merged commit 76fdc89 into main Oct 2, 2025
13 of 15 checks passed
@hamed-musallam
hamed-musallam deleted the fix-assignment-axis branch October 2, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants