feat: support custom label edition on atom - #3668
Merged
Merged
Conversation
tpoisseau
force-pushed
the
3331-numerotation-of-molecules
branch
from
August 29, 2025 11:44
813402d to
5e1a29a
Compare
Deploying nmrium with
|
| Latest commit: |
e71eb3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c753ed3c.nmrium.pages.dev |
| Branch Preview URL: | https://3331-numerotation-of-molecul.nmrium.pages.dev |
tpoisseau
marked this pull request as draft
August 29, 2025 12:17
tpoisseau
force-pushed
the
3331-numerotation-of-molecules
branch
from
August 29, 2025 12:29
5e1a29a to
42247e8
Compare
tpoisseau
marked this pull request as ready for review
August 29, 2025 12:31
Contributor
Author
|
Is it good to you @lpatiny ? |
Member
|
I'm loosing the fact that an atom is assigned. Take the example 
then 'r' + Auto ranges picking. Before when you create a link the atom becomes yellow. Indicated that it has been assigned.
In this PR we are loosing this important feature
|
Contributor
Author
|
switch to |
Member
|
Same behavior is expected in the chemical structures panel |
lpatiny
approved these changes
Aug 29, 2025
lpatiny
left a comment
lpatiny
left a comment
Member
There was a problem hiding this comment.
Functionality looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3331