feat(plugin): support topbar.right plugin ui slot - #3621
Merged
tpoisseau merged 4 commits intoJul 29, 2025
Conversation
* add `PluginUITopBar` demo view * use yalc link (nmrium-core ui slot is in dev) Refs: zakodium/nmrium#350
Contributor
Author
|
To test: In zakodium/nmrium checkout on run In this repository http://localhost:3000/#/SamplesDashboard/bmuvzuny3hf/PluginUITopBardatacytisinedatacytisine1Hjson 
Click on it randomize the icon, state stored in a context wrapping nmrium component. |
tpoisseau
requested review from
hamed-musallam,
stropitek and
targos
and removed request for
hamed-musallam
July 28, 2025 09:13
Deploying nmrium with
|
| Latest commit: |
ea7f571
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://90a215c2.nmrium.pages.dev |
| Branch Preview URL: | https://350-plugins-should-be-able-t.nmrium.pages.dev |
no need yalc link anymore
Member
|
e2e (chromium) is a flake: #3624 |
targos
approved these changes
Jul 29, 2025
targos
changed the title
topbar_right plugin ui slottopbar.right plugin ui slot
tpoisseau
deleted the
350-plugins-should-be-able-to-add-custom-toolbar-buttons
branch
July 29, 2025 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginUITopBardemo view