fix(cluster): robust benchmark/uniprot downloads (User-Agent + optional cache)#231
Merged
Conversation
…al cache) Add a User-Agent header to the UniProt/STRING/CORUM/MSigDB REST calls (headerless requests are increasingly rejected) and an optional cache_path to get_uniprot_data so repeat runs load from disk instead of re-querying. Ported from zarr3. Helps issue #229 (annotation downloads failing). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Robustness fixes for the benchmark/annotation downloads in
lib/cluster/scrape_benchmarks.py(ported from zarr3):cache_pathonget_uniprot_data— if the TSV exists it's loaded without a network call, and a fresh fetch is written there for reuse.Supports #229 (annotation downloads failing).
get_uniprot_dataalready acceptsspecies_id; the analysis-side companion PR exposes it in the configure notebook so non-human screens work.ruff + compile clean; defaults unchanged (cache_path=None ⇒ always fetch).
🤖 Generated with Claude Code