Repository navigation
Add Keenable as an opt-in keyless web provider - #450
Merged
Merged
Conversation
New KeenableSearch client returns the same normalized result over POST /v1/search/public and GET /v1/fetch/public with a fixed X-Keenable-Title header and no key, session or model. web.parallel.configure takes an optional provider allowed only in anonymous mode, quota fencing is scoped per provider, and settings/evidence/setup/lifecycle copy renders per the selected provider with Parallel as the default.
[Medium impact] The PR appears safe to merge; all previous findings are fixed and no new blocking issues were found. SummaryAdds Keenable as an owner-selected, keyless web provider while keeping Parallel as the default.
Reviews (2) · Last reviewed commit: "fix(s14): address Keenable review findin..." · Reviewed by Greptile |
- Read Keenable bodies in chunks and cancel the stream once the byte cap is passed instead of buffering the whole response first. - Keep description-only fetches labelled as excerpts and mark an unmet full-content request partial. - Keep the requested URL in missing when Keenable returns a different page. - Add the five Keenable settings strings to the Thai dictionary so both dictionaries define the same keys (fixes typecheck and i18n test). - Share provider-aware outcome titles with the Progress notice; only quota names the provider, schema/service titles stay neutral. - Regression tests for each finding; ADR 0047 notes the rules.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #449. Keenable becomes a selectable keyless search/fetch provider next to Parallel; Parallel stays the default and nothing changes unless the owner switches in Settings > Web research.
What changed
Test notes
Closes #449