Update release script to build all OSes and do the release - #5
Open
halkeye wants to merge 1 commit into
Open
Conversation
* Switch to GITHUB_TOKEN so its short lived and no secret managements. Uses permissions * Matrix of osses to build all packages * Add flatback because i want it I used claude to help cause i was super lazy
Author
|
https://github.com/halkeye/romm-client/actions/runs/28073958774/job/83114234379 i can't say for certain its uploading assets, i dont' want to run npm publish on my branch |
Owner
|
Thanks for the contribution Minor detail: manual releases may also target the wrong commit. For now linux itself isn't directly supported too but this will come probably soon |
Author
|
thats fair, i think at the time i was still running arch which kept giving me issues with electron, so wanted flatpak to even try it. feel free to cherrypick or close the ticket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used claude to help cause i was super lazy